Remove DNT and X-Mx-ReqToken from default allowed headers#102
Open
mhsdef wants to merge 1 commit intomschae:mainfrom
Open
Remove DNT and X-Mx-ReqToken from default allowed headers#102mhsdef wants to merge 1 commit intomschae:mainfrom
mhsdef wants to merge 1 commit intomschae:mainfrom
Conversation
DNT (Do Not Track) is a browser-set header, not something a client application would send in a cross-origin request, so including it in Access-Control-Allow-Headers serves no purpose. X-Mx-ReqToken was specific to the Mendix platform and is not a general-purpose header that belongs in a CORS library's defaults.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Access-Control-Allow-Headershas no effect.Removing both keeps the default list focused on headers that are actually relevant to typical cross-origin API usage.
This is a backwards-compatible change — anyone who explicitly needs these headers can still add them via the
:headersoption.