Skip to content

fix: Public headers not exposed in objcxx interop #1372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
riteshshukla04 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: Public headers not exposed in objcxx interop #1372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b71819d
chore: app as objcxx interop
riteshshukla04 May 31, 2026
c194635
chore: app as objcxx interop
riteshshukla04 May 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion bun.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions example/ios/NitroExample.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,7 +409,7 @@
PRODUCT_NAME = NitroExample;
SUPPORTED_PLATFORMS = "iphoneos iphonesimulator";
SUPPORTS_MACCATALYST = NO;
SWIFT_OBJC_INTEROP_MODE = objc;
SWIFT_OBJC_INTEROP_MODE = objcxx;
SWIFT_OPTIMIZATION_LEVEL = "-Onone";
SWIFT_VERSION = 5.0;
TARGETED_DEVICE_FAMILY = "1,2";
Expand Down Expand Up @@ -443,7 +443,7 @@
PRODUCT_NAME = NitroExample;
SUPPORTED_PLATFORMS = "iphoneos iphonesimulator";
SUPPORTS_MACCATALYST = NO;
SWIFT_OBJC_INTEROP_MODE = objc;
SWIFT_OBJC_INTEROP_MODE = objcxx;
SWIFT_VERSION = 5.0;
TARGETED_DEVICE_FAMILY = "1,2";
VERSIONING_SYSTEM = "apple-generic";
Expand Down
1 change: 1 addition & 0 deletions example/ios/NitroExample/AppDelegate.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import UIKit
import React
import React_RCTAppDelegate
import ReactAppDependencyProvider
import NitroModules

@main
class AppDelegate: UIResponder, UIApplicationDelegate {
Expand Down
8 changes: 4 additions & 4 deletions example/ios/Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2227,8 +2227,8 @@ EXTERNAL SOURCES:

SPEC CHECKSUMS:
FBLazyVector: 24e62c765683b8d89006a88a2c8f5cf019f0074d
hermes-engine: f0e8ed549bb5a3befb3e292e5c0dafd3e2cee3ab
NitroModules: 16bc17a076b12304d608f7c915b9d321f56dfc19
hermes-engine: ffe60ef62e2a91482e52813d93d1827f6c7297f8
NitroModules: 41e456ee8c8ad54d22957a3e4b3ecab1acbb9e70
NitroTest: 015ec3bddf31c0bd83c0d6d4e10b6d3a42e4e18d
NitroTestExternal: 01bc29bd779142e98432f2178760baebb134de57
RCTDeprecation: a4c521821fab57cbb125b36effe84d897d0dfa12
Expand All @@ -2239,7 +2239,7 @@ SPEC CHECKSUMS:
React: e2dc35338068bbd299c66f043ae0d7f25de8499e
React-callinvoker: 28b25d21b124c26cebaea713ba7d801b9351dc48
React-Core: 02ed7d2ffb70437bdf2aba074a13078a7b0b9ff0
React-Core-prebuilt: 72454b4caa0309d15c45de529b1c5a0e4607cf9a
React-Core-prebuilt: 34bd65b8de409b525d8545cc92b58961427d2015
React-CoreModules: b3a5a42dadcde3b5d47b325bd912eb2ced89e146
React-cxxreact: fe8f88dda044e5905e99a00f41b7a874c3908716
React-debug: 92944dc4d89f56d640e75498266cbde557a48189
Expand Down Expand Up @@ -2303,7 +2303,7 @@ SPEC CHECKSUMS:
ReactAppDependencyProvider: 25c9c516839be2c5e3d3344f95dc7da5f7e63fc2
ReactCodegen: 0f100aa6334186385a43f0dd13d63efc6805ea55
ReactCommon: 7dfc3250793bf36cf221096ff59e1179e13eef7f
ReactNativeDependencies: 86c5427d73b954c0671c6ab9691d486b196595b6
ReactNativeDependencies: df1f53d0ec63baf19e6057b5921e50d5bc45560c
RNScreens: 991cc417cd396602a6cf59a42139e5a9d91462a9
Yoga: 77dfa8673de2874e1855002ae59c68b8be9b007b

Expand Down
28 changes: 2 additions & 26 deletions packages/react-native-nitro-modules/NitroModules.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,32 +33,8 @@ Pod::Spec.new do |s|
]
s.public_header_files = [
# Public C++ headers will be exposed in modulemap (for Swift)
"cpp/core/AnyMap.hpp",
"cpp/core/ArrayBuffer.hpp",
"cpp/core/HybridObject.hpp",
"cpp/core/Null.hpp",
"cpp/core/Promise.hpp",
"cpp/entrypoint/HybridNitroModulesProxy.hpp",
"cpp/entrypoint/InstallNitro.hpp",
"cpp/registry/HybridObjectRegistry.hpp",
"cpp/jsi/JSIConverter.hpp",
"cpp/jsi/JSIHelpers.hpp",
"cpp/platform/NitroLogger.hpp",
"cpp/threading/Dispatcher.hpp",
"cpp/utils/JSCallback.hpp",
"cpp/utils/FastVectorCopy.hpp",
"cpp/utils/NitroHash.hpp",
"cpp/utils/NitroDefines.hpp",
"cpp/utils/PropNameIDCache.hpp",
"cpp/views/CachedProp.hpp",
# Public iOS-specific headers that will be exposed in modulemap (for Swift)
"ios/core/ArrayBufferHolder.hpp",
"ios/core/PromiseHolder.hpp",
"ios/utils/AnyMapUtils.hpp",
"ios/utils/Result.hpp",
"ios/utils/DateToChronoDate.hpp",
"ios/utils/RuntimeError.hpp",
"ios/utils/SwiftClosure.hpp",
"cpp/**/*.hpp",
"ios/**/*.hpp"
]

xcconfig = {
Expand Down
1 change: 0 additions & 1 deletion packages/react-native-nitro-test/NitroTest.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ Pod::Spec.new do |s|

load 'nitrogen/generated/ios/NitroTest+autolinking.rb'
add_nitrogen_files(s)

s.dependency 'React-jsi'
s.dependency 'React-callinvoker'
s.dependency 'NitroTestExternal'
Expand Down
Loading