android: replace prefab cache-busting hack with deterministic task wiring#1337
Draft
mrousavy wants to merge 1 commit into
Draft
android: replace prefab cache-busting hack with deterministic task wiring#1337mrousavy wants to merge 1 commit into
mrousavy wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
fix-prefab.gradleglobally disabled up-to-date checks and mutated generated.cxx/**/prefab_config.jsontimestamps, causing broad Gradle cache invalidation and repeated native reconfiguration/builds..soexists for consuming modules; this should be modeled in the Gradle task graph rather than by mutating generated files.Description
task.outputs.upToDateWhen { false }override fromprefab*ConfigurePackagetasks to avoid forcing non-incremental behavior..cxx/.../prefab_config.jsontimestamps that caused blanket cache invalidation.externalNativeBuild<Variant>task depends on this library'sprefab<Variant>ConfigurePackagetask and declares the prefab task outputs as explicit inputs withPathSensitivity.RELATIVE.packages/react-native-nitro-modules/android/fix-prefab.gradle,packages/template/android/fix-prefab.gradle, andpackages/react-native-nitro-test-external/android/fix-prefab.gradle.Testing
git diffand inspected the patched files withnlto confirm changes applied; these commands succeeded.git addandgit commit; the commit succeeded with messageandroid: replace prefab cache-busting hack with task input wiring.make_pr) to record the change; that operation completed successfully.Codex Task