Skip to content

fix(android): prepare Nitro prefab headers before native clean #1327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Phecda wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −0
Open

fix(android): prepare Nitro prefab headers before native clean #1327

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions packages/react-native-nitro-modules/android/fix-prefab.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,12 @@ tasks.configureEach { task ->

afterEvaluate {
def abis = reactNativeArchitectures()
def prepareHeadersTask = tasks.named("prepareHeaders")

prepareHeadersTask.configure {
mustRunAfter(tasks.named("clean"))

@mrousavy mrousavy May 19, 2026

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this cause prepareHeaders to always do a clean* before too?

@Phecda Phecda May 19, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this only keeps prepareHeaders run after clean if they are both planned to run. prepareHeaders wont trigger a clean itself.
Ref: mustRunAfter

}

rootProject.allprojects.each { proj ->
if (proj === rootProject) return

Expand All @@ -28,6 +34,12 @@ afterEvaluate {
return
}

if (proj != project) {
proj.tasks.matching { it.name.startsWith("externalNativeBuildClean") }.configureEach { cleanTask ->
cleanTask.dependsOn(prepareHeadersTask)
}
}

def variants = proj.android.hasProperty('applicationVariants') ? proj.android.applicationVariants : proj.android.libraryVariants
// Touch the prefab_config.json files to ensure that in ExternalNativeJsonGenerator.kt we will re-trigger the prefab CLI to
// generate a libnameConfig.cmake file that will contain our native library (.so).
Expand Down