Added commands for sorted sets and hyperloglogs#7
Conversation
There was a problem hiding this comment.
Minor: it's better to add spaces between the operator ::
|
LGTM |
|
Ok. Added the return_none, though I'll be honest I don't think it helps much and has nothing to do with zsets or hyperloglogs. |
|
Anything else needed to get this merged? |
|
@mwells , can you please have a look? |
|
bump |
|
Sorry, I let this drop. Will take a look tonight. On Tue, Aug 12, 2014 at 9:08 AM, travisbrady notifications@github.com
|
|
LGTM. Thanks for adding these and sorry for the delay. The only problem is I don't have write access to the repo anymore, so I can't merge the pull request. I don't think @tovbinm does either. Alternatively, I made a fork that I could keep maintaining. Want to send pull request there? I promise to be more timely. |
Remove Batteries
I have a use case for sorted sets (the Z_) commands and hyperloglogs (the PF_ commands) so I thought I'd add them.
Let me know what you think.