Fix CI - run tests && render test results in GitHub UI#43
Merged
mrijken merged 6 commits intomrijken:masterfrom Jul 17, 2025
Merged
Fix CI - run tests && render test results in GitHub UI#43mrijken merged 6 commits intomrijken:masterfrom
mrijken merged 6 commits intomrijken:masterfrom
Conversation
tiberium
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Marc,
I have run the tests locally after you have merged my changes, and one of the assertions in my unit test is now broken (on master!) since typer in the newer version that you have bumped does not send errors to stdout, now - after your changes - it only sends it to stderr.
So I have prepared a simple fix.
Please note that the code should work, but the test fails, and this is a false negative, so should be fixed.
IN ADDITION - I have fixed CI to prevent such issues in future.
Unfortunately, currently, the CI is broken - no tests are actually run during CI...
I have fixed that, with my changes I have:
typeritselfThis is not perfect, but I wrote it fast to provide anything...
This PR will prevent merging into master code that is not passing the tests.
PLEASE NOTE that I have updated the
poetry.lockfile. Now on theubunturunner (used by GitHub in CI), poetry is installing the project dependencies, and that's why I had to "fix" this file.