Skip to content

fix: Fix assertion in JMESPath test after bumping typer#42

Closed
tiberium wants to merge 1 commit intomrijken:masterfrom
tiberium:master
Closed

fix: Fix assertion in JMESPath test after bumping typer#42
tiberium wants to merge 1 commit intomrijken:masterfrom
tiberium:master

Conversation

@tiberium
Copy link
Copy Markdown
Contributor

Hi Marc,
I have run the tests locally after you have merged my changes, and one of the assertions in my unit test is now broken (on master!) since typer in the newer version that you have bumped does not send errors to stdout, now - after your changes - it only sends it to stderr.

So I have prepared a simple fix.
Please note that the code should work, but the test fails, and this is a false negative, so should be fixed.

ANOTHER issue FYI: the poetry lock file requires to be refreshed. Right now it is "broken", since I have resolved conflicts there without doing that through poetry itself, and the metadata-hash seems to be outdated. To fix it, you have to run poetry lock and refresh the file. But on my machine, even when using the same version of Poetry as you are using, poetry is not only setting up a correct metadata.content-hash (which is "broken" now after manually fixing the conflicts in PR39), but also removing some windows-related stuff since I work on arch.

The questions is: is it actually an issue? And do you really want to keep the poetry.lock file in the repository, maybe the pyproject.toml is enough?

@tiberium tiberium closed this Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant