fix: Fix assertion in JMESPath test after bumping typer#42
Closed
tiberium wants to merge 1 commit intomrijken:masterfrom
Closed
fix: Fix assertion in JMESPath test after bumping typer#42tiberium wants to merge 1 commit intomrijken:masterfrom
tiberium wants to merge 1 commit intomrijken:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Marc,
I have run the tests locally after you have merged my changes, and one of the assertions in my unit test is now broken (on master!) since
typerin the newer version that you have bumped does not send errors tostdout, now - after your changes - it only sends it tostderr.So I have prepared a simple fix.
Please note that the code should work, but the test fails, and this is a false negative, so should be fixed.
ANOTHER issue FYI: the poetry lock file requires to be refreshed. Right now it is "broken", since I have resolved conflicts there without doing that through
poetryitself, and themetadata-hashseems to be outdated. To fix it, you have to runpoetry lockand refresh the file. But on my machine, even when using the same version of Poetry as you are using,poetryis not only setting up a correctmetadata.content-hash(which is "broken" now after manually fixing the conflicts in PR39), but also removing some windows-related stuff since I work on arch.The questions is: is it actually an issue? And do you really want to keep the poetry.lock file in the repository, maybe the
pyproject.tomlis enough?