Skip to content

NodeObjectLoader: Fix parseAsync().#33377

Merged
Mugen87 merged 1 commit intomrdoob:devfrom
Mugen87:dev1
Apr 13, 2026
Merged

NodeObjectLoader: Fix parseAsync().#33377
Mugen87 merged 1 commit intomrdoob:devfrom
Mugen87:dev1

Conversation

@Mugen87
Copy link
Copy Markdown
Collaborator

@Mugen87 Mugen87 commented Apr 13, 2026

Fixed #33376.

Description

The PR makes sure parseAsync() is functional when using it with NodeObjectLoader. Previously the version of ObjectLoader was used.

@Mugen87 Mugen87 added this to the r184 milestone Apr 13, 2026
@github-actions
Copy link
Copy Markdown

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 361.21
85.78
361.21
85.78
+0 B
+0 B
WebGPU 637.37
177.04
637.48
177.06
+108 B
+19 B
WebGPU Nodes 635.49
176.75
635.59
176.76
+108 B
+18 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 493.58
120.42
493.58
120.42
+0 B
+0 B
WebGPU 709.22
191.88
709.22
191.88
+0 B
+0 B
WebGPU Nodes 658.44
179.17
658.44
179.17
+0 B
+0 B

@Mugen87 Mugen87 merged commit b09501a into mrdoob:dev Apr 13, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NodeObjectLoader.parseAsync() throws TypeError due to missing method override and null initialization

1 participant