Minify once, after wrapping in function#14
Open
rjmunro wants to merge 2 commits intomrcoles:masterfrom
Open
Conversation
Owner
|
@rjmunro feel free to update based on the latest changes! |
This means the minifier can do a better job because it knows it is safe to mangle variable and function names etc.
rjmunro
force-pushed
the
feature/minify-once
branch
from
203c21d to
af2fbe6
Compare
Author
|
Updated. I've updated the tests, but I'm not sure how to actually run them to ensure they still work. |
bootleq
suggested changes
Dec 14, 2022
| } | ||
|
|
||
| code = `(function(){${code}})()`; | ||
| code = await minify(`(function(){${code}})()`); |
There was a problem hiding this comment.
Minify the whole IIFE produces unexpected result.
You can test the generated output by
./bin/cli.js test/bookmarklets/test1.bookmarklet.js -d > o1.htmlthen open the file and click the Test button within.
In this commit the result is a true appear, while the expected result should be an alert.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This means the minifier can do a better job because it knows it is safe to mangle variable and function names etc.