fix: route localized URLs through Vercel rewrites#10
Merged
Merged
Conversation
Root cause: @astrojs/vercel 8.2.11 doesn't translate Astro's
fallback: { rewrite } config into Vercel routes. The build's
config.json only listed routes for the physical pages
(/account, /docs, etc.), so /pt-br/*, /es/*, /fr/* fell through
to the edge router's 404 before ever reaching the Astro server
function.
Fix:
- vercel.json: rewrites for /pt-br, /es, /fr (plus /:path*) that
internally route to the matching English path with a ?_locale
query parameter so the function still knows the locale.
- Layout.astro: locale resolution now checks ?_locale first, then
Astro.currentLocale (covers local dev), then the URL prefix
(defensive). Vercel preserves the original URL in the browser,
so canonical and hreflang remain correct.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the production 404 on every `/pt-br`, `/es`, `/fr` URL — the root cause that was blocking the multilingual SEO benefit from PR #3.
Root cause
`@astrojs/vercel@8.2.11` doesn't translate Astro's `i18n.fallback: rewrite` config into Vercel routes. The build's `config.json` only listed routes for the physical pages (`/account`, `/docs`, etc.), so requests to localized prefixes fell through to the edge router's 404 before ever reaching the Astro server function.
Fix
Test plan