fix: OpenCV 5 compatibility - #1008
Merged
Merged
Conversation
…ration OpenCV 5 changed two things that broke caliscope: 1. ArUco/Charuco detectBoard returns ids as (N,) instead of (N, 1), and img_loc as (N, 2) instead of (N, 1, 2). The [:, 0] squeeze raised IndexError. Fixed with np.squeeze, which handles both shapes. 2. The default calibrateCamera solver switched to a Schur-complement LM (PR #28461) that converges to bad local minima with sparse data. Fixed by passing CALIB_USE_INTRINSIC_GUESS with a reasonable initial camera matrix, giving both solvers the right basin of convergence. Intrinsic test uses 30 frames instead of 20 to ensure the principal point is well-constrained across solver implementations. Bump to 0.11.3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan