Update z=1 - #249
Merged
Merged
Conversation
mpound
added a commit
that referenced
this pull request
Aug 25, 2026
* Add phase-space limits to LineRatioFit.run (issue #236) (#240) Add radiation_field_range and density_range keywords to LineRatioFit.run() so users can restrict the allowed radiation field (G0) and/or density (n) window and exclude unphysical minima when the data underconstrain the fit. Each keyword accepts a length-2 astropy Quantity (e.g. [100, 1000]*habing_unit) or a length-2 sequence whose elements are each None or a scalar Quantity (e.g. [None, 1e4/u.cm**3] for a one-sided limit). None means no limit on that side. Bounds are converted to the model's linear axis units, and a ValueError is raised up front if a range is malformed, has the wrong units, is inverted, or does not overlap the model grid. The limit is applied in two places: out-of-range cells of the coarse chi-squared grid are masked to +inf before the argmin (on local copies, leaving the stored chisq cubes untouched), and the refine bounds minn/maxn/minfuv/maxfuv are clamped, which propagates to the serial, parallel, and joint fit paths. Adds TestRunLimits covering single-pixel, default-map, and joint-fast paths plus the validation error cases. Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com> * Add smc models (#232) * add TS copy section * simple FITS file spotcheck script for new models * add arguments * update stuff * add smc * update * update issues resolved * update description * Remove OBSGEO header variables that cause fits/wcs to warn. They are not needed for the H2 map notebook * pass kwargs to CCData.read. Rename kwd to kwargs * version * smc notes * remove OBSGEO header keywords * better view * SMC models added! * fix smc tests * update models.tab for CI370 * fix readthedocs building * move old scripts * Add phase-space limits to LineRatioFit.run (issue #236) Add radiation_field_range and density_range keywords to LineRatioFit.run() so users can restrict the allowed radiation field (G0) and/or density (n) window and exclude unphysical minima when the data underconstrain the fit. Each keyword accepts a length-2 astropy Quantity (e.g. [100, 1000]*habing_unit) or a length-2 sequence whose elements are each None or a scalar Quantity (e.g. [None, 1e4/u.cm**3] for a one-sided limit). None means no limit on that side. Bounds are converted to the model's linear axis units, and a ValueError is raised up front if a range is malformed, has the wrong units, is inverted, or does not overlap the model grid. The limit is applied in two places: out-of-range cells of the coarse chi-squared grid are masked to +inf before the argmin (on local copies, leaving the stored chisq cubes untouched), and the refine bounds minn/maxn/minfuv/maxfuv are clamped, which propagates to the serial, parallel, and joint fit paths. Adds TestRunLimits covering single-pixel, default-map, and joint-fast paths plus the validation error cases. * comment out blabby warning, note stuck pixels * no longer used * change smc * update * update for 3.0 * update badges * Add smc models (#248) * add TS copy section * simple FITS file spotcheck script for new models * add arguments * update stuff * add smc * update * update issues resolved * update description * Remove OBSGEO header variables that cause fits/wcs to warn. They are not needed for the H2 map notebook * pass kwargs to CCData.read. Rename kwd to kwargs * version * smc notes * remove OBSGEO header keywords * better view * SMC models added! * fix smc tests * update models.tab for CI370 * fix readthedocs building * move old scripts * Add phase-space limits to LineRatioFit.run (issue #236) Add radiation_field_range and density_range keywords to LineRatioFit.run() so users can restrict the allowed radiation field (G0) and/or density (n) window and exclude unphysical minima when the data underconstrain the fit. Each keyword accepts a length-2 astropy Quantity (e.g. [100, 1000]*habing_unit) or a length-2 sequence whose elements are each None or a scalar Quantity (e.g. [None, 1e4/u.cm**3] for a one-sided limit). None means no limit on that side. Bounds are converted to the model's linear axis units, and a ValueError is raised up front if a range is malformed, has the wrong units, is inverted, or does not overlap the model grid. The limit is applied in two places: out-of-range cells of the coarse chi-squared grid are masked to +inf before the argmin (on local copies, leaving the stored chisq cubes untouched), and the refine bounds minn/maxn/minfuv/maxfuv are clamped, which propagates to the serial, parallel, and joint fit paths. Adds TestRunLimits covering single-pixel, default-map, and joint-fast paths plus the validation error cases. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * comment out blabby warning, note stuck pixels * no longer used * change smc * update * quick script for CenA headers --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com> * Update z=1 (#249) * update badges * updated z=1 models * small changes * fix the H2 characters * add FE models * remove + from 2020 in smc models * reduce decimals in avlos/avperp description * fix m=1000 column for kt2020 * final? edits * new FIST files * typo * aspect = equal default --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updates to the z=1 models (small PDR code changes, no new physics)