Release 3 0 - #2
Merged
Merged
Conversation
Documents the static-site/SSI architecture, the autogen model-page generation workflow, and conventions around templates, includes, and CSS. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Filter ModelSet.all_sets() by name when -m is given. Also fixes two pre-existing bugs that prevented the script from running at all: an unterminated f-string debug print and a missing os.cpu_count() call. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…t level Previously Pool.starmap dispatched one task per ModelSet, so -m <name> (a single ModelSet) ran entirely on one core while the rest sat idle, and uneven ModelSet sizes caused load imbalance. Flatten the work into one task per (ModelSet, ratio) pair instead: register all ModelSets serially (cheap, no plotting), submit every ratio across every selected ModelSet to a single Pool, then aggregate the per-ratio results back into each ModelSet's index.html. Each worker caches its ModelSet/ModelPlot instance across ratios to avoid reloading FITS tables per task. Also: - Add -j/--jobs to control worker count (default: all cores); drop the hardcoded os.cpu_count()-2 reservation. - Skip multiprocessing entirely in -q/--quick mode, which only needs to register ModelSets, not plot them. - Fix a syntax error introduced in d32806c (ms.name="smc" instead of ms.name=="smc"). - Fix a latent bug where ms.keyname was mutated in-place for T_e (ionized gas) ratios and could leak into the tarball link on the ModelSet's index page if such a ratio was processed last; now tracked as a local variable per ratio instead. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Documents skip_modelset, Page, and its methods. A few parameters (z's exact reference/units, the ratio identifier format) are marked with TODO(Marc) placeholders where the meaning wasn't certain from the code alone. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update web site for pdrtpy release 3.0.1