Fix: pass ws_opts to :gun.ws_upgrade/4#120
Merged
Merged
Conversation
ws_opts nested inside gun_opts was documented but never actually forwarded to the WebSocket upgrade call. Extract ws_opts from gun_opts and pass it explicitly via :gun.ws_upgrade/4.
mpol1t
approved these changes
Jul 14, 2026
mpol1t
left a comment
mpol1t
left a comment
Owner
There was a problem hiding this comment.
Looks good to me. Thanks for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ws_optsnested insidegun_optsis documented but was never forwarded to the WebSocket upgrade callws_optsfromgun_optsand pass it explicitly via:gun.ws_upgrade/4ws_optsreaches the upgrade callContext
:gun.ws_upgrade/3does not inheritws_optsfrom the connection opts passed to:gun.open/3. The 4-arity:gun.ws_upgrade/4must be used to pass WebSocket-specific options likekeepaliveandsilence_pings.