Skip to content

feat(downloads): clear completed and failed downloads #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mpiton merged 10 commits into from
Apr 17, 2026
Merged

feat(downloads): clear completed and failed downloads #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
156884e
docs: implementation plan for clear completed/failed downloads
mpiton Apr 17, 2026
b7839ca
feat(download): add clear_downloads_by_state command handler
mpiton Apr 17, 2026
89b78ee
feat(download): expose clear-completed and clear-failed IPC
mpiton Apr 17, 2026
7c5fc12
feat(downloads): add ClearDownloadsDialog + sonner + i18n keys
mpiton Apr 17, 2026
d9b1cdd
feat(downloads): wire Clear completed/failed buttons in ActionsBar
mpiton Apr 17, 2026
588966c
docs: changelog entry for clear completed/failed downloads
mpiton Apr 17, 2026
77fc99a
fix(download): address adversarial review findings
mpiton Apr 17, 2026
b2f145d
fix(download): address PR #75 review comments
mpiton Apr 17, 2026
b88311d
style: apply cargo fmt to clear_downloads_by_state.rs
mpiton Apr 17, 2026
45c62f7
style: collapse nested if into let-chain for clippy
mpiton Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- `SegmentStarted` event now carries `start_byte` and `end_byte` so downstream consumers can identify which byte range a segment covers

### Added
- **Clear completed / Clear failed downloads**: two new toolbar buttons in the Downloads view, separated from the bulk actions by a vertical separator. Each opens a confirmation dialog with an optional "Also delete files from disk" checkbox gated behind a prominent red warning panel. Success and error outcomes are reported via toasts.
- `sonner` toast notifications (new dependency) mounted globally in `App.tsx`, with a thin `src/lib/toast.ts` wrapper so components do not depend on the library directly.
- YouTube 1080p+ support: when `resolve_stream_url` returns `AdaptiveStreamOnly`,
`download_media_start` now falls back to `download_to_file` which delegates the
full DASH download + ffmpeg merge to yt-dlp. The merged file is moved to the
Expand Down
Loading
Loading