fix(filter): passthrough gh pr/issue filters when user supplies --json/-q/--jq#382
Open
sumitparakh wants to merge 1 commit into
Open
fix(filter): passthrough gh pr/issue filters when user supplies --json/-q/--jq#382sumitparakh wants to merge 1 commit into
sumitparakh wants to merge 1 commit into
Conversation
…n/-q/--jq Unconditional run overrides that inject --json would conflict with user-supplied --json/--jq/-q flags, causing the on_success template to render empty fields. Adding these flags to passthrough_args skips the filter entirely when detected, preserving the user's intended output. Fixes mpecan#381
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unconditional run overrides that inject --json would conflict with user-supplied --json/--jq/-q flags, causing the on_success template to render empty fields. Adding these flags to passthrough_args skips the filter entirely when detected, preserving the user's intended output.
Fixes #381