Skip to content

Added spaces between extensions when copying the list of extensions #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
whimboo merged 3 commits into from
Aug 23, 2016
Merged

Added spaces between extensions when copying the list of extensions #195

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d8a9eed
Added spaces between the extensions when copying the list of extensio…
UtiluMark Oct 5, 2015
ddeb1c6
Changed newlines-separation to comma-separation
UtiluMark Oct 21, 2015
bfd4884
Moved join to insertExtensions and copyExtensions
UtiluMark Aug 22, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions extension/chrome/content/nightly.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,7 @@ getExtensionList: function(callback) {
+ (addon.userDisabled || addon.appDisabled ? " [DISABLED]" : "");
});
strings.sort(nightly.insensitiveSort);
callback(strings.join("\n"));
callback(strings);
});
} catch(e) {
// old extension manager API - take out after Firefox 3.6 support dropped

@whimboo whimboo Oct 13, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not relevant to this PR but we should get a new issue created so the old API can finally be removed.

Expand Down Expand Up @@ -395,7 +395,7 @@ getExtensionList: function(callback) {
catch (e) { }
}
text.sort(nightly.insensitiveSort);
callback(text.join("\n"));
callback(text);
}
},

Expand All @@ -407,7 +407,7 @@ insertExtensions: function() {
nightly.getExtensionList(function(text) {
var newpos = element.selectionStart + text.length;
var value = element.value;
element.value = value.substring(0, element.selectionStart) + text +
element.value = value.substring(0, element.selectionStart) + text.join(", ") +
value.substring(element.selectionEnd);
element.selectionStart = newpos;
element.selectionEnd = newpos;
Expand All @@ -421,7 +421,7 @@ insertExtensions: function() {
copyExtensions: function() {
nightly.getExtensionList(function(text) {
if (text)
nightly.copyText(text);
nightly.copyText(text.join(", "));
});
},

Expand Down