chore: Fix clippy#3584
Merged
larseggert merged 1 commit intomozilla:mainfrom May 4, 2026
Merged
Conversation
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
Updates a debug logging path in Connection::log_packet to satisfy clippy by simplifying write! formatting usage.
Changes:
- Remove a needless borrow in
write!by using Rust’s captured identifier formatting ({x}) instead of passing&x.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3584 +/- ##
==========================================
- Coverage 95.00% 94.85% -0.15%
==========================================
Files 109 114 +5
Lines 37586 37931 +345
Branches 37586 37931 +345
==========================================
+ Hits 35709 35980 +271
- Misses 1187 1251 +64
- Partials 690 700 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Contributor
Benchmark resultsNo significant performance differences relative to ffa0aa2. All resultstransfer/1-conn/1-100mb-resp (aka. Download): Change within noise threshold. time: [200.47 ms 200.86 ms 201.26 ms]
thrpt: [496.88 MiB/s 497.87 MiB/s 498.83 MiB/s]
change:
time: [-1.0067% -0.6831% -0.3951] (p = 0.00 < 0.05)
thrpt: [+0.3967% +0.6878% +1.0169]
Change within noise threshold.
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mildtransfer/1-conn/10_000-parallel-1b-resp (aka. RPS): No change in performance detected. time: [285.92 ms 287.50 ms 289.08 ms]
thrpt: [34.592 Kelem/s 34.783 Kelem/s 34.974 Kelem/s]
change:
time: [-1.3927% -0.4673% +0.4049] (p = 0.31 > 0.05)
thrpt: [-0.4032% +0.4695% +1.4124]
No change in performance detected.transfer/1-conn/1-1b-resp (aka. HPS): No change in performance detected. time: [38.744 ms 38.951 ms 39.189 ms]
thrpt: [25.518 B/s 25.673 B/s 25.811 B/s]
change:
time: [-0.7962% -0.0381% +0.7513] (p = 0.92 > 0.05)
thrpt: [-0.7457% +0.0381% +0.8026]
No change in performance detected.
Found 10 outliers among 100 measurements (10.00%)
10 (10.00%) high severetransfer/1-conn/1-100mb-req (aka. Upload): No change in performance detected. time: [203.55 ms 204.10 ms 204.78 ms]
thrpt: [488.32 MiB/s 489.96 MiB/s 491.28 MiB/s]
change:
time: [-0.0045% +0.3266% +0.7014] (p = 0.07 > 0.05)
thrpt: [-0.6965% -0.3255% +0.0045]
No change in performance detected.
Found 3 outliers among 100 measurements (3.00%)
1 (1.00%) high mild
2 (2.00%) high severestreams/walltime/1-streams/each-1000-bytes: No change in performance detected. time: [586.35 µs 589.34 µs 592.61 µs]
change: [-0.4360% +0.2194% +0.8793] (p = 0.52 > 0.05)
No change in performance detected.
Found 18 outliers among 100 measurements (18.00%)
1 (1.00%) high mild
17 (17.00%) high severestreams/walltime/1000-streams/each-1-bytes: Change within noise threshold. time: [12.250 ms 12.268 ms 12.287 ms]
change: [-0.5070% -0.3038% -0.0948] (p = 0.01 < 0.05)
Change within noise threshold.streams/walltime/1000-streams/each-1000-bytes: Change within noise threshold. time: [44.295 ms 44.342 ms 44.390 ms]
change: [-0.6645% -0.3014% -0.0399] (p = 0.05 < 0.05)
Change within noise threshold.
Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high mildtransfer/walltime/pacing-false/varying-seeds: Change within noise threshold. time: [23.331 ms 23.357 ms 23.391 ms]
change: [-1.9214% -1.6884% -1.4912] (p = 0.00 < 0.05)
Change within noise threshold.
Found 5 outliers among 100 measurements (5.00%)
1 (1.00%) low mild
1 (1.00%) high mild
3 (3.00%) high severetransfer/walltime/pacing-true/varying-seeds: Change within noise threshold. time: [23.655 ms 23.683 ms 23.722 ms]
change: [-1.7909% -1.6249% -1.4514] (p = 0.00 < 0.05)
Change within noise threshold.
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high severetransfer/walltime/pacing-false/same-seed: Change within noise threshold. time: [23.424 ms 23.453 ms 23.492 ms]
change: [+0.1989% +0.4502% +0.6721] (p = 0.00 < 0.05)
Change within noise threshold.
Found 2 outliers among 100 measurements (2.00%)
1 (1.00%) high mild
1 (1.00%) high severetransfer/walltime/pacing-true/same-seed: Change within noise threshold. time: [24.033 ms 24.056 ms 24.083 ms]
change: [-1.0665% -0.8432% -0.6662] (p = 0.00 < 0.05)
Change within noise threshold.
Found 2 outliers among 100 measurements (2.00%)
1 (1.00%) high mild
1 (1.00%) high severeDownload data for |
Contributor
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-pr as client
neqo-pr as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-pr as client
neqo-pr as server
|
Contributor
Client/server transfer resultsPerformance differences relative to ffa0aa2. Transfer of 33554432 bytes over loopback, min. 100 runs. All unit-less numbers are in milliseconds.
Table above only shows statistically significant changes. See all results below. All resultsTransfer of 33554432 bytes over loopback, min. 100 runs. All unit-less numbers are in milliseconds.
Download data for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.