fix: Does symbol localization actually help?#3582
Closed
larseggert wants to merge 3 commits intomozilla:mainfrom
Closed
fix: Does symbol localization actually help?#3582larseggert wants to merge 3 commits intomozilla:mainfrom
larseggert wants to merge 3 commits intomozilla:mainfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3582 +/- ##
==========================================
+ Coverage 94.85% 94.87% +0.01%
==========================================
Files 114 114
Lines 37931 38017 +86
Branches 37931 38017 +86
==========================================
+ Hits 35979 36067 +88
+ Misses 1252 1250 -2
Partials 700 700
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Collaborator
Author
|
Seems to make no difference and is super intrusive. |
Contributor
Benchmark resultsNo significant performance differences relative to c032e66. All resultstransfer/1-conn/1-100mb-resp (aka. Download): Change within noise threshold. time: [200.23 ms 200.61 ms 201.10 ms]
thrpt: [497.26 MiB/s 498.47 MiB/s 499.43 MiB/s]
change:
time: [-1.3607% -1.0881% -0.7887] (p = 0.00 < 0.05)
thrpt: [+0.7950% +1.1001% +1.3795]
Change within noise threshold.
Found 2 outliers among 100 measurements (2.00%)
1 (1.00%) high mild
1 (1.00%) high severetransfer/1-conn/10_000-parallel-1b-resp (aka. RPS): No change in performance detected. time: [282.95 ms 284.95 ms 286.99 ms]
thrpt: [34.845 Kelem/s 35.094 Kelem/s 35.342 Kelem/s]
change:
time: [-1.6793% -0.7555% +0.1478] (p = 0.10 > 0.05)
thrpt: [-0.1476% +0.7613% +1.7080]
No change in performance detected.
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mildtransfer/1-conn/1-1b-resp (aka. HPS): No change in performance detected. time: [38.778 ms 38.970 ms 39.185 ms]
thrpt: [25.520 B/s 25.661 B/s 25.788 B/s]
change:
time: [-0.3036% +0.3445% +1.0534] (p = 0.31 > 0.05)
thrpt: [-1.0424% -0.3434% +0.3045]
No change in performance detected.
Found 10 outliers among 100 measurements (10.00%)
1 (1.00%) high mild
9 (9.00%) high severetransfer/1-conn/1-100mb-req (aka. Upload): Change within noise threshold. time: [203.00 ms 203.42 ms 203.90 ms]
thrpt: [490.43 MiB/s 491.58 MiB/s 492.61 MiB/s]
change:
time: [-0.6859% -0.3946% -0.0954] (p = 0.01 < 0.05)
thrpt: [+0.0954% +0.3962% +0.6906]
Change within noise threshold.
Found 3 outliers among 100 measurements (3.00%)
1 (1.00%) high mild
2 (2.00%) high severestreams/walltime/1-streams/each-1000-bytes: Change within noise threshold. time: [587.21 µs 588.51 µs 590.17 µs]
change: [-0.9507% -0.4842% -0.0269] (p = 0.04 < 0.05)
Change within noise threshold.
Found 3 outliers among 100 measurements (3.00%)
3 (3.00%) high severestreams/walltime/1000-streams/each-1-bytes: Change within noise threshold. time: [12.280 ms 12.297 ms 12.315 ms]
change: [-1.1836% -0.7383% -0.4057] (p = 0.00 < 0.05)
Change within noise threshold.
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mildstreams/walltime/1000-streams/each-1000-bytes: Change within noise threshold. time: [44.846 ms 44.921 ms 45.024 ms]
change: [+0.2636% +0.4562% +0.7143] (p = 0.00 < 0.05)
Change within noise threshold.
Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high severetransfer/walltime/pacing-false/varying-seeds: Change within noise threshold. time: [22.946 ms 22.978 ms 23.025 ms]
change: [-0.7444% -0.5828% -0.3561] (p = 0.00 < 0.05)
Change within noise threshold.
Found 5 outliers among 100 measurements (5.00%)
3 (3.00%) high mild
2 (2.00%) high severetransfer/walltime/pacing-true/varying-seeds: Change within noise threshold. time: [23.257 ms 23.283 ms 23.316 ms]
change: [-0.7504% -0.6273% -0.4564] (p = 0.00 < 0.05)
Change within noise threshold.
Found 4 outliers among 100 measurements (4.00%)
3 (3.00%) high mild
1 (1.00%) high severetransfer/walltime/pacing-false/same-seed: No change in performance detected. time: [23.105 ms 23.131 ms 23.168 ms]
change: [-0.2165% -0.0794% +0.0801] (p = 0.37 > 0.05)
No change in performance detected.
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high severetransfer/walltime/pacing-true/same-seed: Change within noise threshold. time: [23.798 ms 23.830 ms 23.875 ms]
change: [+1.1225% +1.2799% +1.4725] (p = 0.00 < 0.05)
Change within noise threshold.
Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high severeDownload data for |
Contributor
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-pr as client
neqo-pr as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-pr as client
neqo-pr as server
|
Contributor
Client/server transfer resultsPerformance differences relative to c032e66. Transfer of 33554432 bytes over loopback, min. 100 runs. All unit-less numbers are in milliseconds.
Table above only shows statistically significant changes. See all results below. All resultsTransfer of 33554432 bytes over loopback, min. 100 runs. All unit-less numbers are in milliseconds.
Download data for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See slides 80+ of https://raw.githubusercontent.com/yugr/rust-slides/main/EN.pdf