chore: prepare v0.25.0#3510
Conversation
There was a problem hiding this comment.
Pull request overview
Prepares the Neqo workspace for the v0.24.2 sub-release by updating the workspace/package versioning artifacts.
Changes:
- Bump workspace package version to
0.24.2in the rootCargo.toml. - Update workspace crate versions in
Cargo.lockto0.24.2.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Cargo.toml | Updates [workspace.package] version to 0.24.2 for the release. |
| Cargo.lock | Syncs lockfile workspace package versions to 0.24.2. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3510 +/- ##
==========================================
- Coverage 94.36% 94.24% -0.13%
==========================================
Files 127 131 +4
Lines 38825 39155 +330
Branches 38825 39155 +330
==========================================
+ Hits 36638 36901 +263
- Misses 1348 1407 +59
- Partials 839 847 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Merging this PR will improve performance by 4.73%
Performance Changes
Comparing Footnotes
|
mxinden
left a comment
There was a problem hiding this comment.
Fine with v0.24.2 or v0.25.0.
2fe110a to
2bcceec
Compare
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-pr as client
neqo-pr as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-pr as client
neqo-pr as server
|
Client/server transfer resultsPerformance differences relative to 64a36e2. Transfer of 33554432 bytes over loopback, min. 100 runs. All unit-less numbers are in milliseconds.
Table above only shows statistically significant changes. See all results below. All resultsTransfer of 33554432 bytes over loopback, min. 100 runs. All unit-less numbers are in milliseconds.
Download data for |
Benchmark resultsNo significant performance differences relative to 64a36e2. All resultstransfer/1-conn/1-100mb-resp (aka. Download)/mtu-1504: Change within noise threshold. time: [204.13 ms 204.47 ms 204.87 ms]
thrpt: [488.13 MiB/s 489.07 MiB/s 489.89 MiB/s]
change:
time: [+0.8318% +1.1062% +1.3827] (p = 0.00 < 0.05)
thrpt: [-1.3638% -1.0941% -0.8249]
Change within noise threshold.
Found 4 outliers among 100 measurements (4.00%)
1 (1.00%) low mild
1 (1.00%) high mild
2 (2.00%) high severetransfer/1-conn/10_000-parallel-1b-resp (aka. RPS)/mtu-1504: No change in performance detected. time: [282.52 ms 284.42 ms 286.33 ms]
thrpt: [34.924 Kelem/s 35.160 Kelem/s 35.395 Kelem/s]
change:
time: [-0.2442% +0.7611% +1.6989] (p = 0.12 > 0.05)
thrpt: [-1.6705% -0.7553% +0.2448]
No change in performance detected.transfer/1-conn/1-1b-resp (aka. HPS)/mtu-1504: No change in performance detected. time: [38.494 ms 38.624 ms 38.768 ms]
thrpt: [25.794 B/s 25.890 B/s 25.978 B/s]
change:
time: [-0.4370% +0.1402% +0.7168] (p = 0.64 > 0.05)
thrpt: [-0.7117% -0.1400% +0.4389]
No change in performance detected.
Found 11 outliers among 100 measurements (11.00%)
8 (8.00%) high mild
3 (3.00%) high severetransfer/1-conn/1-100mb-req (aka. Upload)/mtu-1504: Change within noise threshold. time: [205.46 ms 205.93 ms 206.51 ms]
thrpt: [484.24 MiB/s 485.61 MiB/s 486.71 MiB/s]
change:
time: [+0.3407% +0.6501% +0.9862] (p = 0.00 < 0.05)
thrpt: [-0.9766% -0.6459% -0.3396]
Change within noise threshold.
Found 2 outliers among 100 measurements (2.00%)
1 (1.00%) high mild
1 (1.00%) high severestreams/walltime/1-streams/each-1000-bytes: Change within noise threshold. time: [586.00 µs 588.07 µs 590.48 µs]
change: [-1.1238% -0.6010% -0.0604] (p = 0.03 < 0.05)
Change within noise threshold.
Found 8 outliers among 100 measurements (8.00%)
8 (8.00%) high severestreams/walltime/1000-streams/each-1-bytes: Change within noise threshold. time: [12.277 ms 12.315 ms 12.373 ms]
change: [-1.4323% -1.0841% -0.6347] (p = 0.00 < 0.05)
Change within noise threshold.
Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high severestreams/walltime/1000-streams/each-1000-bytes: Change within noise threshold. time: [45.087 ms 45.136 ms 45.184 ms]
change: [+0.2552% +0.4111% +0.5679] (p = 0.00 < 0.05)
Change within noise threshold.
Found 3 outliers among 100 measurements (3.00%)
1 (1.00%) low mild
2 (2.00%) high mildtransfer/walltime/pacing-false/varying-seeds: Change within noise threshold. time: [81.945 ms 82.006 ms 82.068 ms]
change: [+0.7104% +0.9011% +1.0746] (p = 0.00 < 0.05)
Change within noise threshold.
Found 2 outliers among 100 measurements (2.00%)
1 (1.00%) low mild
1 (1.00%) high mildtransfer/walltime/pacing-true/varying-seeds: Change within noise threshold. time: [83.078 ms 83.127 ms 83.177 ms]
change: [+0.5203% +0.6698% +0.8055] (p = 0.00 < 0.05)
Change within noise threshold.transfer/walltime/pacing-false/same-seed: Change within noise threshold. time: [83.440 ms 83.486 ms 83.534 ms]
change: [+2.9248% +3.1480% +3.3570] (p = 0.00 < 0.05)
Change within noise threshold.
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mildtransfer/walltime/pacing-true/same-seed: Change within noise threshold. time: [83.533 ms 83.589 ms 83.650 ms]
change: [+1.3503% +1.4470% +1.5485] (p = 0.00 < 0.05)
Change within noise threshold.
Found 3 outliers among 100 measurements (3.00%)
3 (3.00%) high mildDownload data for |
Preparing a new sub-release to get the fixes to HyStart++ in.
What's Changed
pacing_rateandssthreshin qlog by @larseggert in feat: emitpacing_rateandssthreshin qlog #3435New Contributors