chore: prepare v0.24.0#3481
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3481 +/- ##
==========================================
- Coverage 94.29% 94.19% -0.11%
==========================================
Files 127 131 +4
Lines 38739 39069 +330
Branches 38739 39069 +330
==========================================
+ Hits 36528 36800 +272
- Misses 1372 1420 +48
- Partials 839 849 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
We can't land SCONE without #3460 or an alternative @martinthomson is working on. |
I would really like to get HyStart++ in to get experimentation started. I see the linked PR already has a patch, so I assume it might merge soon? If it might take a while, maybe we could do a release without SCONE? |
fb63bec to
880037d
Compare
|
We can totally release without SCONE. We can also add a connection parameter for SCONE (without the fix) and default it to off for now. (@martinthomson prefers to not loop, and so is trying to get the SCONE spec to disallow multiple markings: ietf-wg-scone/scone#143) |
|
If possible, I would also like to include these in the next revision (still need landing): |
|
The connection parameter was already added in #3450, it will now be getting defaulted to off with #3492. If possible I would like to get a release out today because I need to start experimentation early next week and it will probably take a bit to get reviews for the release on the gecko side. I'm also fine doing a dot release next week to get stuff in that didn't land today. |
I reviewed each of them. I suggest proceeding here. With #3460 merged, I don't think anything else is blocking Neqo |
880037d to
53de273
Compare
There was a problem hiding this comment.
Pull request overview
Prepares the Neqo workspace for the v0.24.0 release by bumping the workspace package version and updating the lockfile so member crate versions are consistent. This aligns with the release goal of shipping recent transport/CC, stats, SCONE, and qlog work into downstream consumers (e.g., Firefox).
Changes:
- Bump
[workspace.package]version from0.23.1to0.24.0. - Update
Cargo.lockentries for workspace crates to reflect0.24.0.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
Cargo.toml |
Updates the workspace package version to 0.24.0. |
Cargo.lock |
Syncs lockfile workspace crate versions to 0.24.0. |
You can also share your feedback on Copilot code review. Take the survey.
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-pr as client
neqo-pr as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-pr as client
neqo-pr as server
|
Client/server transfer resultsPerformance differences relative to 7c5faa7. No significant performance differences. Table above only shows statistically significant changes. See all results below. All resultsTransfer of 33554432 bytes over loopback, min. 100 runs. All unit-less numbers are in milliseconds.
Download data for |
Benchmark resultsNo significant performance differences relative to ef4ac2b. All resultstransfer/1-conn/1-100mb-resp (aka. Download)/mtu-1504: Change within noise threshold. time: [201.74 ms 202.16 ms 202.65 ms]
thrpt: [493.47 MiB/s 494.67 MiB/s 495.69 MiB/s]
change:
time: [+0.4130% +0.6917% +0.9998] (p = 0.00 < 0.05)
thrpt: [-0.9899% -0.6869% -0.4113]
Change within noise threshold.
Found 4 outliers among 100 measurements (4.00%)
3 (3.00%) low mild
1 (1.00%) high severetransfer/1-conn/10_000-parallel-1b-resp (aka. RPS)/mtu-1504: No change in performance detected. time: [287.27 ms 289.22 ms 291.24 ms]
thrpt: [34.336 Kelem/s 34.576 Kelem/s 34.811 Kelem/s]
change:
time: [-0.4587% +0.5423% +1.5841] (p = 0.28 > 0.05)
thrpt: [-1.5594% -0.5394% +0.4608]
No change in performance detected.
Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high mildtransfer/1-conn/1-1b-resp (aka. HPS)/mtu-1504: No change in performance detected. time: [38.509 ms 38.627 ms 38.760 ms]
thrpt: [25.800 B/s 25.889 B/s 25.968 B/s]
change:
time: [-0.3421% +0.1676% +0.6945] (p = 0.52 > 0.05)
thrpt: [-0.6897% -0.1673% +0.3432]
No change in performance detected.
Found 3 outliers among 100 measurements (3.00%)
3 (3.00%) high severetransfer/1-conn/1-100mb-req (aka. Upload)/mtu-1504: Change within noise threshold. time: [204.57 ms 205.11 ms 205.80 ms]
thrpt: [485.92 MiB/s 487.55 MiB/s 488.83 MiB/s]
change:
time: [+0.0491% +0.3837% +0.7311] (p = 0.03 < 0.05)
thrpt: [-0.7258% -0.3823% -0.0491]
Change within noise threshold.
Found 5 outliers among 100 measurements (5.00%)
1 (1.00%) low mild
2 (2.00%) high mild
2 (2.00%) high severestreams/walltime/1-streams/each-1000-bytes: Change within noise threshold. time: [586.43 µs 590.23 µs 596.04 µs]
change: [+0.2403% +1.0312% +2.1325] (p = 0.01 < 0.05)
Change within noise threshold.
Found 7 outliers among 100 measurements (7.00%)
7 (7.00%) high severestreams/walltime/1000-streams/each-1-bytes: Change within noise threshold. time: [12.499 ms 12.519 ms 12.540 ms]
change: [+0.9552% +1.1928% +1.4351] (p = 0.00 < 0.05)
Change within noise threshold.
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high severestreams/walltime/1000-streams/each-1000-bytes: Change within noise threshold. time: [45.152 ms 45.251 ms 45.407 ms]
change: [+0.0691% +0.3251% +0.7284] (p = 0.02 < 0.05)
Change within noise threshold.
Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high severetransfer/walltime/pacing-false/varying-seeds: Change within noise threshold. time: [79.901 ms 80.004 ms 80.145 ms]
change: [+2.1404% +2.2887% +2.4782] (p = 0.00 < 0.05)
Change within noise threshold.
Found 3 outliers among 100 measurements (3.00%)
1 (1.00%) low severe
1 (1.00%) high mild
1 (1.00%) high severetransfer/walltime/pacing-true/varying-seeds: Change within noise threshold. time: [80.083 ms 80.199 ms 80.366 ms]
change: [+0.4625% +0.6314% +0.8265] (p = 0.00 < 0.05)
Change within noise threshold.
Found 4 outliers among 100 measurements (4.00%)
2 (2.00%) high mild
2 (2.00%) high severetransfer/walltime/pacing-false/same-seed: Change within noise threshold. time: [80.126 ms 80.218 ms 80.332 ms]
change: [+0.1430% +0.2715% +0.4207] (p = 0.00 < 0.05)
Change within noise threshold.
Found 4 outliers among 100 measurements (4.00%)
1 (1.00%) low mild
1 (1.00%) high mild
2 (2.00%) high severetransfer/walltime/pacing-true/same-seed: Change within noise threshold. time: [80.005 ms 80.143 ms 80.314 ms]
change: [+0.3554% +0.5476% +0.7445] (p = 0.00 < 0.05)
Change within noise threshold.
Found 7 outliers among 100 measurements (7.00%)
7 (7.00%) high severeDownload data for |
I would like to cut a new release to get HyStart++ into Firefox, which would be the following changes:
cwndstat is now initialized to the initial window size by @omansfeld in fix(stats/cc):cwndstat is now initialized to the initial window size #3454w_maxby @omansfeld in feat(stats): add a stat recording cubic's w_max #3431Other most notable changes in that release would be SCONE (which will still be defaulted off):
And the QLOG changes:
congestion_state_updatedby @larseggert in feat: add trigger to qlogcongestion_state_updated#3436recovery:loss_timer_updatedqlog events by @larseggert in feat: addrecovery:loss_timer_updatedqlog events #3437Blocked on #3431Blocked on #3460