Skip to content

chore: Fix searchfox URL#2553

Merged
larseggert merged 1 commit intomozilla:mainfrom
larseggert:chore-fix-searchfox
Apr 3, 2025
Merged

chore: Fix searchfox URL#2553
larseggert merged 1 commit intomozilla:mainfrom
larseggert:chore-fix-searchfox

Conversation

@larseggert
Copy link
Copy Markdown
Collaborator

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 3, 2025

Failed Interop Tests

QUIC Interop Runner, client vs. server, differences relative to 9354a53.

neqo-latest as client

neqo-latest as server

All results

Succeeded Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

Unsupported Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

@larseggert larseggert added this pull request to the merge queue Apr 3, 2025
Copy link
Copy Markdown
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Merged via the queue into mozilla:main with commit a8b2b75 Apr 3, 2025
81 checks passed
@larseggert larseggert deleted the chore-fix-searchfox branch April 3, 2025 09:25
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 3, 2025

Benchmark results

Performance differences relative to 9354a53.

1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: No change in performance detected.
       time:   [714.81 ms 718.90 ms 722.98 ms]
       thrpt:  [138.32 MiB/s 139.10 MiB/s 139.90 MiB/s]
change:
       time:   [-0.3850% +0.4560% +1.2940%] (p = 0.29 > 0.05)
       thrpt:  [-1.2775% -0.4540% +0.3864%]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: No change in performance detected.
       time:   [347.69 ms 349.54 ms 351.38 ms]
       thrpt:  [28.460 Kelem/s 28.609 Kelem/s 28.762 Kelem/s]
change:
       time:   [-0.5370% +0.2232% +0.9219%] (p = 0.54 > 0.05)
       thrpt:  [-0.9135% -0.2227% +0.5399%]
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: No change in performance detected.
       time:   [25.040 ms 25.195 ms 25.352 ms]
       thrpt:  [39.444  elem/s 39.691  elem/s 39.936  elem/s]
change:
       time:   [-0.4453% +0.4281% +1.3333%] (p = 0.34 > 0.05)
       thrpt:  [-1.3158% -0.4263% +0.4473%]
1-conn/1-100mb-req/mtu-1504 (aka. Upload)/client: No change in performance detected.
       time:   [1.8748 s 1.8994 s 1.9254 s]
       thrpt:  [51.937 MiB/s 52.649 MiB/s 53.340 MiB/s]
change:
       time:   [-3.2618% -1.6675% +0.0362%] (p = 0.05 > 0.05)
       thrpt:  [-0.0362% +1.6958% +3.3717%]

Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high mild

decode 4096 bytes, mask ff: No change in performance detected.
       time:   [11.986 µs 12.015 µs 12.052 µs]
       change: [-0.6742% -0.0911% +0.4954%] (p = 0.78 > 0.05)

Found 14 outliers among 100 measurements (14.00%)
2 (2.00%) low severe
2 (2.00%) low mild
2 (2.00%) high mild
8 (8.00%) high severe

decode 1048576 bytes, mask ff: No change in performance detected.
       time:   [2.9432 ms 2.9488 ms 2.9562 ms]
       change: [-0.3351% -0.0213% +0.2955%] (p = 0.86 > 0.05)

Found 3 outliers among 100 measurements (3.00%)
3 (3.00%) high severe

decode 4096 bytes, mask 7f: No change in performance detected.
       time:   [20.025 µs 20.081 µs 20.142 µs]
       change: [-0.6900% +0.0050% +0.7795%] (p = 0.99 > 0.05)

Found 20 outliers among 100 measurements (20.00%)
3 (3.00%) low severe
1 (1.00%) low mild
2 (2.00%) high mild
14 (14.00%) high severe

decode 1048576 bytes, mask 7f: No change in performance detected.
       time:   [4.7949 ms 4.8077 ms 4.8211 ms]
       change: [-0.2691% +0.1157% +0.4958%] (p = 0.56 > 0.05)

Found 15 outliers among 100 measurements (15.00%)
15 (15.00%) high severe

decode 4096 bytes, mask 3f: No change in performance detected.
       time:   [6.3205 µs 6.3457 µs 6.3778 µs]
       change: [-0.0015% +0.6438% +1.3887%] (p = 0.08 > 0.05)

Found 19 outliers among 100 measurements (19.00%)
4 (4.00%) low severe
1 (1.00%) low mild
2 (2.00%) high mild
12 (12.00%) high severe

decode 1048576 bytes, mask 3f: No change in performance detected.
       time:   [2.1526 ms 2.1599 ms 2.1684 ms]
       change: [-0.3137% +0.1996% +0.7167%] (p = 0.44 > 0.05)

Found 11 outliers among 100 measurements (11.00%)
1 (1.00%) high mild
10 (10.00%) high severe

1 streams of 1 bytes/multistream: Change within noise threshold.
       time:   [70.276 µs 70.498 µs 70.722 µs]
       change: [-1.8714% -1.3955% -0.8821%] (p = 0.00 < 0.05)
1000 streams of 1 bytes/multistream: No change in performance detected.
       time:   [25.285 ms 25.319 ms 25.354 ms]
       change: [-0.3626% -0.1727% +0.0135%] (p = 0.07 > 0.05)

Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild

10000 streams of 1 bytes/multistream: Change within noise threshold.
       time:   [1.6883 s 1.6900 s 1.6918 s]
       change: [-0.7798% -0.6398% -0.4885%] (p = 0.00 < 0.05)

Found 23 outliers among 100 measurements (23.00%)
13 (13.00%) low mild
4 (4.00%) high mild
6 (6.00%) high severe

1 streams of 1000 bytes/multistream: No change in performance detected.
       time:   [72.848 µs 74.410 µs 76.410 µs]
       change: [+0.1316% +2.4005% +5.2110%] (p = 0.06 > 0.05)

Found 4 outliers among 100 measurements (4.00%)
4 (4.00%) high severe

100 streams of 1000 bytes/multistream: No change in performance detected.
       time:   [3.3476 ms 3.3542 ms 3.3612 ms]
       change: [-0.4134% -0.1165% +0.1854%] (p = 0.45 > 0.05)

Found 21 outliers among 100 measurements (21.00%)
21 (21.00%) high severe

1000 streams of 1000 bytes/multistream: Change within noise threshold.
       time:   [143.39 ms 143.47 ms 143.54 ms]
       change: [+0.0661% +0.1377% +0.2085%] (p = 0.00 < 0.05)

Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high mild

coalesce_acked_from_zero 1+1 entries: No change in performance detected.
       time:   [95.010 ns 95.399 ns 95.787 ns]
       change: [-0.6279% -0.0502% +0.4885%] (p = 0.87 > 0.05)

Found 14 outliers among 100 measurements (14.00%)
10 (10.00%) high mild
4 (4.00%) high severe

coalesce_acked_from_zero 3+1 entries: No change in performance detected.
       time:   [113.27 ns 113.65 ns 114.04 ns]
       change: [-0.2943% +0.2713% +0.8797%] (p = 0.41 > 0.05)

Found 18 outliers among 100 measurements (18.00%)
1 (1.00%) low severe
2 (2.00%) low mild
15 (15.00%) high severe

coalesce_acked_from_zero 10+1 entries: No change in performance detected.
       time:   [112.43 ns 112.76 ns 113.19 ns]
       change: [-0.5632% -0.0695% +0.4443%] (p = 0.80 > 0.05)

Found 17 outliers among 100 measurements (17.00%)
5 (5.00%) low severe
5 (5.00%) low mild
1 (1.00%) high mild
6 (6.00%) high severe

coalesce_acked_from_zero 1000+1 entries: No change in performance detected.
       time:   [93.492 ns 93.955 ns 94.440 ns]
       change: [-1.9381% -0.6659% +0.5845%] (p = 0.32 > 0.05)

Found 9 outliers among 100 measurements (9.00%)
7 (7.00%) high mild
2 (2.00%) high severe

RxStreamOrderer::inbound_frame(): Change within noise threshold.
       time:   [117.04 ms 117.10 ms 117.16 ms]
       change: [+0.3383% +0.4151% +0.4916%] (p = 0.00 < 0.05)

Found 11 outliers among 100 measurements (11.00%)
3 (3.00%) low mild
8 (8.00%) high mild

SentPackets::take_ranges: No change in performance detected.
       time:   [8.3803 µs 8.6144 µs 8.8402 µs]
       change: [-0.1773% +3.3248% +6.8152%] (p = 0.06 > 0.05)

Found 19 outliers among 100 measurements (19.00%)
4 (4.00%) low severe
11 (11.00%) low mild
3 (3.00%) high mild
1 (1.00%) high severe

transfer/pacing-false/varying-seeds: No change in performance detected.
       time:   [35.593 ms 35.664 ms 35.737 ms]
       change: [-0.2816% -0.0006% +0.2973%] (p = 0.99 > 0.05)

Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) low mild

transfer/pacing-true/varying-seeds: Change within noise threshold.
       time:   [35.726 ms 35.789 ms 35.853 ms]
       change: [-1.5994% -1.3655% -1.1278%] (p = 0.00 < 0.05)

Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild

transfer/pacing-false/same-seed: Change within noise threshold.
       time:   [36.076 ms 36.133 ms 36.190 ms]
       change: [+0.3473% +0.5749% +0.8165%] (p = 0.00 < 0.05)
transfer/pacing-true/same-seed: Change within noise threshold.
       time:   [36.203 ms 36.244 ms 36.285 ms]
       change: [-0.7654% -0.6038% -0.4426%] (p = 0.00 < 0.05)

Found 3 outliers among 100 measurements (3.00%)
2 (2.00%) low mild
1 (1.00%) high mild

Client/server transfer results

Performance differences relative to 9354a53.

Transfer of 33554432 bytes over loopback, 30 runs. All unit-less numbers are in milliseconds.

Client Server CC Pacing Mean ± σ Min Max MiB/s ± σ Δ main Δ main
neqo neqo reno on 414.7 ± 34.4 389.4 559.1 77.2 ± 0.9 0.8 0.2%
neqo neqo reno 459.8 ± 156.0 388.6 1162.8 69.6 ± 0.2 -15.6 -3.3%
neqo neqo cubic on 407.3 ± 33.0 371.2 548.7 78.6 ± 1.0 -2.3 -0.6%
neqo neqo cubic 418.7 ± 55.9 383.7 585.5 76.4 ± 0.6 14.2 3.5%
google neqo reno on 766.8 ± 86.8 571.8 902.7 41.7 ± 0.4 1.2 0.2%
google neqo reno 764.0 ± 82.5 549.7 844.7 41.9 ± 0.4 -5.6 -0.7%
google neqo cubic on 769.6 ± 80.4 596.9 906.7 41.6 ± 0.4 10.1 1.3%
google neqo cubic 772.0 ± 80.9 616.5 954.6 41.5 ± 0.4 13.1 1.7%
google google 585.4 ± 59.8 549.2 778.1 54.7 ± 0.5 12.4 2.2%
neqo msquic reno on 274.1 ± 37.7 243.7 408.2 116.7 ± 0.8 8.1 3.0%
neqo msquic reno 271.3 ± 36.4 244.3 443.4 118.0 ± 0.9 3.5 1.3%
neqo msquic cubic on 270.0 ± 33.3 241.4 418.2 118.5 ± 1.0 3.0 1.1%
neqo msquic cubic 268.9 ± 36.0 246.2 445.2 119.0 ± 0.9 4.7 1.8%
msquic msquic 180.5 ± 39.2 147.3 351.4 177.3 ± 0.8 -0.3 -0.2%

⬇️ Download logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants