Skip to content

Fix measures causing lookml validation error#1444

Merged
scholtzan merged 1 commit into
mainfrom
fix-measures-actual_uapi
Jun 3, 2026
Merged

Fix measures causing lookml validation error#1444
scholtzan merged 1 commit into
mainfrom
fix-measures-actual_uapi

Conversation

@scholtzan scholtzan enabled auto-merge June 3, 2026 16:42
@scholtzan scholtzan disabled auto-merge June 3, 2026 16:42
@scholtzan scholtzan merged commit da66a51 into main Jun 3, 2026
11 checks passed
@scholtzan scholtzan deleted the fix-measures-actual_uapi branch June 3, 2026 16:43
@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown

Integration report for "this commit"

lookml.diff

Click to expand!
Only in /tmp/workspace/looker-hub/firefox_ios: dashboards
Only in /tmp/workspace/looker-hub/marketing: datagroups
Only in /tmp/workspace/looker-hub/search_private/datagroups: search_term_data_validation_reports_last_updated.datagroup.lkml
Only in /tmp/workspace/looker-hub/search_private/datagroups: search_term_sanitization_job_metadata_daily_last_updated.datagroup.lkml
Only in /tmp/workspace/looker-hub/: user_journey
diff -x '.*' -bur --no-dereference --new-file /tmp/workspace/looker-hub/ads/views/forecast_content_monthly.view.lkml /tmp/workspace/generated-lookml/ads/views/forecast_content_monthly.view.lkml
--- /tmp/workspace/looker-hub/ads/views/forecast_content_monthly.view.lkml	2026-06-03 16:51:15.534380890 +0000
+++ /tmp/workspace/generated-lookml/ads/views/forecast_content_monthly.view.lkml	2026-06-03 16:51:10.303764147 +0000
@@ -240,18 +240,13 @@
     value_to_date: no
   }
 
-  measure: actual_uapi_clicks {
-    sql: ${actual_uapi_clicks} ;;
-    type: sum
-  }
-
   measure: actual_uapi_clicks_excluding_house_ads_sum {
     sql: ${actual_uapi_clicks_excluding_house_ads} ;;
     type: sum
   }
 
-  measure: actual_uapi_impressions {
-    sql: ${actual_uapi_impressions} ;;
+  measure: actual_uapi_clicks_total {
+    sql: ${actual_uapi_clicks} ;;
     type: sum
   }
 
@@ -260,6 +255,11 @@
     type: sum
   }
 
+  measure: actual_uapi_impressions_total {
+    sql: ${actual_uapi_impressions} ;;
+    type: sum
+  }
+
   measure: fill_rate {
     sql: SAFE_DIVIDE(${actual_uapi_impressions_excluding_house_ads_sum},${forecast_native_inventory_sum}) ;;
     type: number
diff -x '.*' -bur --no-dereference --new-file /tmp/workspace/looker-hub/marketing/datagroups/firefox_for_families_forecasted_expectations_last_updated.datagroup.lkml /tmp/workspace/generated-lookml/marketing/datagroups/firefox_for_families_forecasted_expectations_last_updated.datagroup.lkml
--- /tmp/workspace/looker-hub/marketing/datagroups/firefox_for_families_forecasted_expectations_last_updated.datagroup.lkml	2026-06-03 16:51:15.598121703 +0000
+++ /tmp/workspace/generated-lookml/marketing/datagroups/firefox_for_families_forecasted_expectations_last_updated.datagroup.lkml	1970-01-01 00:00:00.000000000 +0000
@@ -1,20 +0,0 @@
-# *Do not manually modify this file*
-
-# This file has been generated via https://github.com/mozilla/lookml-generator
-
-# Using a datagroup in an Explore: https://cloud.google.com/looker/docs/reference/param-explore-persist-with
-# Using a datagroup in a derived table: https://cloud.google.com/looker/docs/reference/param-view-datagroup-trigger
-
-datagroup: firefox_for_families_forecasted_expectations_last_updated {
-  label: "firefox_for_families_forecasted_expectations Last Updated"
-  sql_trigger: SELECT MAX(storage_last_modified_time)
-    FROM (
-        
-    SELECT MAX(storage_last_modified_time) AS storage_last_modified_time
-    FROM `mozdata`.`region-us`.INFORMATION_SCHEMA.TABLE_STORAGE
-    WHERE (table_schema = 'analysis' AND table_name = 'marketing_firefox_for_families_forecasted_expectations')
-
-    ) ;;
-  description: "Updates for firefox_for_families_forecasted_expectations when referenced tables are modified."
-  max_cache_age: "24 hours"
-}
\ No newline at end of file
diff -x '.*' -bur --no-dereference --new-file /tmp/workspace/looker-hub/namespaces.yaml /tmp/workspace/generated-lookml/namespaces.yaml
--- /tmp/workspace/looker-hub/namespaces.yaml	2026-06-03 16:51:15.846862071 +0000
+++ /tmp/workspace/generated-lookml/namespaces.yaml	2026-06-03 16:51:15.785860995 +0000
@@ -586,18 +586,18 @@
           period: month
           type: period_over_period
           value_to_date: 'no'
-        actual_uapi_clicks:
-          sql: ${actual_uapi_clicks}
-          type: sum
         actual_uapi_clicks_excluding_house_ads_sum:
           sql: ${actual_uapi_clicks_excluding_house_ads}
           type: sum
-        actual_uapi_impressions:
-          sql: ${actual_uapi_impressions}
+        actual_uapi_clicks_total:
+          sql: ${actual_uapi_clicks}
           type: sum
         actual_uapi_impressions_excluding_house_ads_sum:
           sql: ${actual_uapi_impressions_excluding_house_ads}
           type: sum
+        actual_uapi_impressions_total:
+          sql: ${actual_uapi_impressions}
+          type: sum
         fill_rate:
           sql: SAFE_DIVIDE(${actual_uapi_impressions_excluding_house_ads_sum},${forecast_native_inventory_sum})
           type: number
diff -x '.*' -bur --no-dereference --new-file /tmp/workspace/looker-hub/search_private/datagroups/search_term_data_validation_reports_last_updated.datagroup.lkml /tmp/workspace/generated-lookml/search_private/datagroups/search_term_data_validation_reports_last_updated.datagroup.lkml
--- /tmp/workspace/looker-hub/search_private/datagroups/search_term_data_validation_reports_last_updated.datagroup.lkml	2026-06-03 16:51:15.656524738 +0000
+++ /tmp/workspace/generated-lookml/search_private/datagroups/search_term_data_validation_reports_last_updated.datagroup.lkml	1970-01-01 00:00:00.000000000 +0000
@@ -1,20 +0,0 @@
-# *Do not manually modify this file*
-
-# This file has been generated via https://github.com/mozilla/lookml-generator
-
-# Using a datagroup in an Explore: https://cloud.google.com/looker/docs/reference/param-explore-persist-with
-# Using a datagroup in a derived table: https://cloud.google.com/looker/docs/reference/param-view-datagroup-trigger
-
-datagroup: search_term_data_validation_reports_last_updated {
-  label: "search_term_data_validation_reports Last Updated"
-  sql_trigger: SELECT MAX(storage_last_modified_time)
-    FROM (
-        
-    SELECT MAX(storage_last_modified_time) AS storage_last_modified_time
-    FROM `moz-fx-data-shared-prod`.`region-us`.INFORMATION_SCHEMA.TABLE_STORAGE
-    WHERE (table_schema = 'search_terms_derived' AND table_name = 'search_term_data_validation_reports_v1')
-
-    ) ;;
-  description: "Updates for search_term_data_validation_reports when referenced tables are modified."
-  max_cache_age: "24 hours"
-}
\ No newline at end of file
diff -x '.*' -bur --no-dereference --new-file /tmp/workspace/looker-hub/search_private/datagroups/search_term_sanitization_job_metadata_daily_last_updated.datagroup.lkml /tmp/workspace/generated-lookml/search_private/datagroups/search_term_sanitization_job_metadata_daily_last_updated.datagroup.lkml
--- /tmp/workspace/looker-hub/search_private/datagroups/search_term_sanitization_job_metadata_daily_last_updated.datagroup.lkml	2026-06-03 16:51:15.656555374 +0000
+++ /tmp/workspace/generated-lookml/search_private/datagroups/search_term_sanitization_job_metadata_daily_last_updated.datagroup.lkml	1970-01-01 00:00:00.000000000 +0000
@@ -1,20 +0,0 @@
-# *Do not manually modify this file*
-
-# This file has been generated via https://github.com/mozilla/lookml-generator
-
-# Using a datagroup in an Explore: https://cloud.google.com/looker/docs/reference/param-explore-persist-with
-# Using a datagroup in a derived table: https://cloud.google.com/looker/docs/reference/param-view-datagroup-trigger
-
-datagroup: search_term_sanitization_job_metadata_daily_last_updated {
-  label: "search_term_sanitization_job_metadata_daily Last Updated"
-  sql_trigger: SELECT MAX(storage_last_modified_time)
-    FROM (
-        
-    SELECT MAX(storage_last_modified_time) AS storage_last_modified_time
-    FROM `moz-fx-data-shared-prod`.`region-us`.INFORMATION_SCHEMA.TABLE_STORAGE
-    WHERE (table_schema = 'search_terms_derived' AND table_name = 'sanitization_job_metadata_v2')
-
-    ) ;;
-  description: "Updates for search_term_sanitization_job_metadata_daily when referenced tables are modified."
-  max_cache_age: "24 hours"
-}
\ No newline at end of file
diff -x '.*' -bur --no-dereference --new-file /tmp/workspace/looker-hub/user_journey/views/events_daily.view.lkml /tmp/workspace/generated-lookml/user_journey/views/events_daily.view.lkml
--- /tmp/workspace/looker-hub/user_journey/views/events_daily.view.lkml	2026-06-03 16:51:15.661370397 +0000
+++ /tmp/workspace/generated-lookml/user_journey/views/events_daily.view.lkml	1970-01-01 00:00:00.000000000 +0000
@@ -1,71 +0,0 @@
-view: events_daily {
-  sql_table_name: `mozdata.messaging_system.events_daily`
-    ;;
-
-  dimension: addon_version {
-    type: string
-    sql: ${TABLE}.addon_version ;;
-  }
-
-  dimension: app_version {
-    type: string
-    sql: ${TABLE}.app_version ;;
-  }
-
-  dimension: city {
-    type: string
-    sql: ${TABLE}.city ;;
-  }
-
-  dimension: client_id {
-    type: string
-    sql: ${TABLE}.client_id ;;
-  }
-
-  dimension: country {
-    type: string
-    map_layer_name: countries
-    sql: ${TABLE}.country ;;
-  }
-
-  dimension: events {
-    type: string
-    sql: ${TABLE}.events ;;
-    hidden: yes
-  }
-
-  dimension: experiments {
-    hidden: yes
-    sql: ${TABLE}.experiments ;;
-  }
-
-  dimension: locale {
-    type: string
-    sql: ${TABLE}.locale ;;
-  }
-
-  dimension: normalized_channel {
-    type: string
-    sql: ${TABLE}.normalized_channel ;;
-  }
-
-  dimension: os {
-    type: string
-    sql: ${TABLE}.os ;;
-  }
-
-  dimension: sample_id {
-    type: number
-    sql: ${TABLE}.sample_id ;;
-  }
-
-  dimension: subdivision1 {
-    type: string
-    sql: ${TABLE}.subdivision1 ;;
-  }
-
-  dimension: submission_date {
-    type: date
-    sql: CAST(${TABLE}.submission_date AS TIMESTAMP) ;;
-  }
-}

Link to full diff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant