-
Notifications
You must be signed in to change notification settings - Fork 824
Add a string about re-login on avatar change & Correct several strings #7084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
(This PR replaces #7010) |
|
Converting to draft until I clarify how Pontoon handles the formatting |
|
Well, it should look fine on Pontoon |
escattone
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @denyshon! I just have one small suggested change, but otherwise it looks great.
| <p> | ||
| {# L10n: Mozilla Support refers to https://support.mozilla.org #} | ||
| {% trans a_open='<a href="https://support.mozilla.org">'|safe, a_close='</a>'|safe %} | ||
| After changing your avatar, you will have to re-login on {{ a_open }}Mozilla Support{{ a_close }} for the changes to be applied. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you change the wording of this a bit? Instead of re-login, I think log in again would be better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@escattone Sure! Maybe sign in again would be even better (since we have the Sign in button)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's even better, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@escattone done
3ac2593 to
6507af0
Compare
| <p> | ||
| {# L10n: Mozilla Support refers to https://support.mozilla.org #} | ||
| {% trans a_open='<a href="https://support.mozilla.org">'|safe, a_close='</a>'|safe %} | ||
| After changing your avatar, you will have to re-login on {{ a_open }}Mozilla Support{{ a_close }} for the changes to be applied. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's change this one too, from re-login to sign in again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@escattone Done. Sorry, missed that one
Add a string about required re-login on avatar change Remove "en-US" from the links Remove unnecessary spaces Replace the hyphen with a dash Add l10n comments
6507af0 to
d14945d
Compare
escattone
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @denyshon!
Resolves #5446.
Old strings are kept as deprecated to preserve existing translations and give localizers time to transfer them. We'll remove those strings later.