Skip to content

Conversation

@denyshon
Copy link
Contributor

  • Add a string about required re-login on avatar change
  • Remove "en-US" from the links
  • Add l10n comments
  • Remove unnecessary spaces
  • Replace the hyphen with a dash

Resolves #5446.

Old strings are kept as deprecated to preserve existing translations and give localizers time to transfer them. We'll remove those strings later.

@denyshon
Copy link
Contributor Author

(This PR replaces #7010)

@denyshon denyshon marked this pull request as draft November 27, 2025 13:53
@denyshon
Copy link
Contributor Author

Converting to draft until I clarify how Pontoon handles the formatting

@denyshon
Copy link
Contributor Author

Well, it should look fine on Pontoon

@denyshon denyshon marked this pull request as ready for review November 27, 2025 14:11
Copy link
Contributor

@escattone escattone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @denyshon! I just have one small suggested change, but otherwise it looks great.

<p>
{# L10n: Mozilla Support refers to https://support.mozilla.org #}
{% trans a_open='<a href="https://support.mozilla.org">'|safe, a_close='</a>'|safe %}
After changing your avatar, you will have to re-login on {{ a_open }}Mozilla Support{{ a_close }} for the changes to be applied.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change the wording of this a bit? Instead of re-login, I think log in again would be better.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@escattone Sure! Maybe sign in again would be even better (since we have the Sign in button)?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's even better, thanks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@escattone done

<p>
{# L10n: Mozilla Support refers to https://support.mozilla.org #}
{% trans a_open='<a href="https://support.mozilla.org">'|safe, a_close='</a>'|safe %}
After changing your avatar, you will have to re-login on {{ a_open }}Mozilla Support{{ a_close }} for the changes to be applied.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's change this one too, from re-login to sign in again.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@escattone Done. Sorry, missed that one

Add a string about required re-login on avatar change
Remove "en-US" from the links
Remove unnecessary spaces
Replace the hyphen with a dash
Add l10n comments
Copy link
Contributor

@escattone escattone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @denyshon!

@escattone escattone merged commit f120f0d into mozilla:main Jan 6, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add hint on required relogging for SuMo avatar change to take effect

2 participants