Fix covariate adjustment looking up preenrollment table by metric name instead of data source#3275
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In discrete-metrics mode, metric tables are partitioned by data source (
{slug}_{basis}_{data_source_name}_{period}_{idx}), with each metric as a column. But covariate adjustment looked up the preenrollment table by metric name, so the table never existed and adjustment silently fell back to unadjusted inferences every time.Fixed both the query builder (
_create_subset_metric_table_query_covariate) and the Dask prerequisite computation (_subset_metric_table_prerequisites) to resolve the table by data source name. Since a covariate can be a different metric than the during-experiment metric, the new_covariate_table_metric_namehelper looks up the covariate metric's own data source.