Recreate canvas and renderer when component remount#38
Open
vincentfretin wants to merge 10 commits intomozilla:mainfrom
Open
Recreate canvas and renderer when component remount#38vincentfretin wants to merge 10 commits intomozilla:mainfrom
vincentfretin wants to merge 10 commits intomozilla:mainfrom
Conversation
…if we don't catch it now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is based on #37. Only the latest commit is new.
The changes are good if you want to use the
AvatarEditorContainercomponent in aDialogcomponent that you can show and hide inside your react app.The threejs renderer is created when the
AvatarPreviewContainermount and is disposed when the component unmount.I created the functions
window.gameState.initRendererandwindow.gameState.disposeRendererand refactored game.js to create only once the scene, and recreate the envmap and controls when the component is remounted.Instead of setting
material.envMapof each material, I just set it once withscene.environment.I also added
sky.geometry.dispose();sky.material.dispose();to properly clean up sky geometry and material.I'm using
renderer.setAnimationLoop(tick)instead of handling the loop withwindow.requestAnimationFrame(tick);.This way the loop is stopped automatically when disposing the renderer, so we don't need to handle a state ourself.