glean-build: 2 improvements: Allow to overwrite venv dir in code & allow to change format#3442
Merged
glean-build: 2 improvements: Allow to overwrite venv dir in code & allow to change format#3442
Conversation
badboy
force-pushed
the
push-vmsokvmppxrv
branch
from
0fa3dc6 to
d95c829
Compare
jeddai
reviewed
Apr 23, 2026
Member
jeddai
left a comment
jeddai
left a comment
There was a problem hiding this comment.
I see the env_dir member on Builder but I don't see where that can be set in the args, is there something I'm missing there? Or is it meant to only be used in code?
Member
Author
I see the
|
jeddai
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-work for #3426