feat(nimbus): Support Firefox Labs on Fenix#16200
Open
freshstrangemusic wants to merge 1 commit into
Open
Conversation
freshstrangemusic
requested review from
RJAK11,
jaredlockhart,
mikewilli and
yashikakhurana
as code owners
jaredlockhart
left a comment
jaredlockhart
left a comment
Collaborator
There was a problem hiding this comment.
Generally looks good, some thoughts about the test setups.
freshstrangemusic
force-pushed
the
freshstrangemusic/push-mnyqkqrkxtvo
branch
6 times, most recently
from
0f10427 to
14ccbce
Compare
Member
Author
|
@jaredlockhart i split apart all the huge generators into multiple indivudal tests |
Because: - Fenix supports Firefox Labs as of Firefox 154+; - the constants the controlled in what applications supported Firefox Labs were spread across `NimbusConstants` instead of being associated with the application configuuration; and - Firefox version constants were declared quite late in `NimbusConstants`, making them unavailable to `ApplicationConfig` inststances this commit: - refactors `NimbusConstants.Version` into `experimenter.experiments.versions`; - refactors all the Firefox Labs fields in `NimbusConstants` into a new dataclass that is used with `ApplicationConfig`; - updates Firefox Desktop and Fenix's application configs to use the new FirefoxLabs dataclass; - updates branches form rendering to conditionally render Firefox Labs fields when supported in the application config; - updates available choices for firefox_labs_group to be based on the application; and - updates the existing unit tests to be generic across all Firefox Labs-supporting applications. Fixes #16199
freshstrangemusic
force-pushed
the
freshstrangemusic/push-mnyqkqrkxtvo
branch
from
14ccbce to
fdfd825
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because:
NimbusConstantsinstead of being associated with the application configuuration; andNimbusConstants, making them unavailable toApplicationConfiginststancesthis commit:
NimbusConstants.Versionintoexperimenter.experiments.versions;NimbusConstantsinto a new dataclass that is used withApplicationConfig;Fixes #16199