Conversation
Because * we need to add Mermaid diagrams reflecting the new rollout-specific state machine This commit * adds the Mermaid diagrams for rollouts * updates timeout flows to return to idle after timeout Fixes #16153
Contributor
Author
|
During our diagram review meeting and local testing, we found that when a Remote Settings review times out, the owner has to request review again. Because of that, we updated the timeout flows to reflect this behavior. We may need to make the same kind of update to the experiment diagrams as well. |
Contributor
|
Also worth noting that @freshstrangemusic mentioned that rollout pause only works for the labs, what will happen for non labs rollouts, will it keep the pause behaviour as expected that means users who are already enrolled will still enrolled, but no users will be enrolled 👀 |
Because * we need to add Mermaid diagrams reflecting the new rollout-specific state machine This commit * adds the Mermaid diagrams for rollouts * updates timeout flows to return to idle after timeout Fixes #16153
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This commit
Fixes #16153