feat(nimbus): add is_holdback, do_rerun, do_rerun_timestamp fields to model and v8 API#16096
Merged
Conversation
added 2 commits
June 23, 2026 15:24
… model and v8 API
Add isHoldback/doRerun/doRerunTimestamp to the v8 serializer test schema and is_holdback/do_rerun/do_rerun_timestamp to the changelog serializer expected dicts, and regenerate the OpenAPI schema and Swagger docs to include the new fields.
yashikakhurana
requested review from
freshstrangemusic,
jaredlockhart and
mikewilli
as code owners
moibra05
reviewed
Jun 29, 2026
Comment on lines
+1584
to
+1586
| "doRerunTimestamp": { | ||
| "type": "string", | ||
| "readOnly": true |
Contributor
There was a problem hiding this comment.
should this also include "format": "date-time"?
Suggested change
| "doRerunTimestamp": { | |
| "type": "string", | |
| "readOnly": true | |
| "doRerunTimestamp": { | |
| "type": "string", | |
| "readOnly": true | |
| "format": "date-time", |
mikewilli
approved these changes
Jun 30, 2026
mikewilli
left a comment
mikewilli
left a comment
Contributor
There was a problem hiding this comment.
LGTM -- And forgot that the API uses camelCase instead of snake so I think I'll have to make an update on the Jetstream side.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This commit
is_holdback,do_rerun, anddo_rerun_timestampfields to theNimbusExperimentmodel and exposes them in the v8 API asisHoldback,doRerun, anddoRerunTimestamp.Related
fixes #16087