Skip to content

Taskbartabs topsites#16084

Draft
AllegroFox wants to merge 1 commit into
mainfrom
taskbartabs-topsites
Draft

Taskbartabs topsites#16084
AllegroFox wants to merge 1 commit into
mainfrom
taskbartabs-topsites

Conversation

@AllegroFox

Copy link
Copy Markdown
Contributor

Adds targeting to support the "Top Sites" taskbar tabs spotlight experiment.

  • browser.taskbarTabs.enabled == true
  • no web app currently pinned (measure net-new adoption)
  • profileAge 7+ days
  • Windows only (taskbar tabs is currently limited to Windows)

@jaredlockhart

Copy link
Copy Markdown
Collaborator

Ah @AllegroFox

FAILED experimenter/targeting/tests/test_targeting_configs.py::TestTargetingConfigs::test_validate_targeting_config_fields_305 - AssertionError: {'installedWebAppsCount'} is not false : Unknown targeting fields in existing_windows_user_taskbar_tabs_enabled_but_not_used: {'installedWebAppsCount'}

installedWebAppsCount is not instrumented as a Nimbus targeting field:

See docs here https://experimenter.info/platform-guides/desktop/targeting#adding-new-targeting-options

@AllegroFox AllegroFox force-pushed the taskbartabs-topsites branch from 97fe980 to 9dc11b2 Compare June 23, 2026 19:40
@AllegroFox AllegroFox marked this pull request as draft June 23, 2026 19:41
@AllegroFox

Copy link
Copy Markdown
Contributor Author

Ah @AllegroFox

FAILED experimenter/targeting/tests/test_targeting_configs.py::TestTargetingConfigs::test_validate_targeting_config_fields_305 - AssertionError: {'installedWebAppsCount'} is not false : Unknown targeting fields in existing_windows_user_taskbar_tabs_enabled_but_not_used: {'installedWebAppsCount'}

installedWebAppsCount is not instrumented as a Nimbus targeting field:

See docs here https://experimenter.info/platform-guides/desktop/targeting#adding-new-targeting-options

Ah shoot, I overlooked that! I thought I had tested it through the Nimbus Devtools and it was present. In that case, I think we'll go with keeping that part of the targeting at the message level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants