Skip to content

feat(nimbus): Add Rollout Schedule Card#16063

Open
RJAK11 wants to merge 1 commit into
mainfrom
15081
Open

feat(nimbus): Add Rollout Schedule Card#16063
RJAK11 wants to merge 1 commit into
mainfrom
15081

Conversation

@RJAK11

@RJAK11 RJAK11 commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Because

  • We need to be able to manage rollout schedules from the rollout summary page

This commit

  • Adds a rollout schedule card with phase dates and population percentages
  • Adds support for adding and removing rollout phases
  • Shows rollout phase progress with ability to pause/resume/start buttons

Fixes #15081

Screen.Recording.2026-06-22.at.10.28.23.AM.mov
Screen.Recording.2026-06-22.at.11.41.37.AM.mov
schedule.demo.mp4

@moibra05 moibra05 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found a couple bugs testing locally:

  • its possible to set only the start or end date without the other. im not sure if this is intentional
  • deleting/adding a phase then cancelling the form does not undo the phase action

besides that i think the code looks really good to me :)

Comment thread experimenter/experimenter/experiments/models.py

@yashikakhurana yashikakhurana left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @RJAK11 this is great, overall looks good, just some design changes

Image Image we will move all the controls like start phase etc etc left side on the sidebar, so this start here will not required Image

@RJAK11 RJAK11 force-pushed the 15081 branch 2 times, most recently from 682aed3 to e2b8a7e Compare June 25, 2026 16:25
@RJAK11

RJAK11 commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

Thank you both for the reviews! I have addressed all the mentioned issues and you can see the changes in the video. For the bug regarding deleting/adding a phase then cancelling the form not undoing the action, I initially avoided that to prevent introducing some complicated code but I just added it with the other changes. Let me know if this approach looks okay or if you think there’s a better way to handle it 🙏🏼

Screen.Recording.2026-06-25.at.11.14.20.AM.mov

@RJAK11 RJAK11 requested a review from yashikakhurana June 25, 2026 17:19

@yashikakhurana yashikakhurana left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general looks good, thank you @RJAK11, some suggestion, some views and urls are not needed now as we are not adding pause/start here

Comment thread experimenter/experimenter/nimbus_ui/urls.py
Comment thread experimenter/experimenter/nimbus_ui/urls.py
Comment thread experimenter/experimenter/nimbus_ui/urls.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rollout Schedule Form/Card

3 participants