Skip to content

fix(nimbus): fix retention displaying incorrect values#15351

Open
moibra05 wants to merge 1 commit into
mainfrom
12647
Open

fix(nimbus): fix retention displaying incorrect values#15351
moibra05 wants to merge 1 commit into
mainfrom
12647

Conversation

@moibra05

Copy link
Copy Markdown
Contributor

Because

  • We were not showing week 2 retention on the main page for experiments that ran for less than 2 weeks and for those still in the observation phase

This commit

  • Adds an analysis error if an experiment was running for less than 2 weeks and was thus unable to get week 2 retention data
  • Applies a similar approach to fix(nimbus): fix 3 days retention showing incorrect values #15287 where we only keep the second window index in the weekly analysis basis for retention so that we are not displaying incorrect values

Fixes #12647

@moibra05

Copy link
Copy Markdown
Contributor Author

Once merged, this unblocks #15239

@jaredlockhart jaredlockhart left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay sorry for not getting back to this, let's just merge it so at least it's functioning, and if we find we need to change its behaviour we can do that as a followup. Thanks for fixing this and reminding me to review 🙈 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do not fall back to week-1 retention when week-2 is not available

2 participants