Skip to content

Add an alias for web_feature field#529

Merged
jgraham merged 1 commit into
mainfrom
web_feature_alias
May 27, 2026
Merged

Add an alias for web_feature field#529
jgraham merged 1 commit into
mainfrom
web_feature_alias

Conversation

@ksy36
Copy link
Copy Markdown
Contributor

@ksy36 ksy36 commented May 26, 2026

The job has been failing with:

[2026-05-26, 16:17:32 UTC] {pod_manager.py:477} INFO - [base] INFO:root:Running job standards-positions
[2026-05-26, 16:17:32 UTC] {pod_manager.py:477} INFO - [base] INFO:httpx:HTTP Request: GET https://api.github.com/repos/mozilla/standards-positions/contents/merged-data.json?ref=gh-pages "HTTP/1.1 200 OK"
[2026-05-26, 16:17:32 UTC] {pod_manager.py:477} INFO - [base] INFO:httpx:HTTP Request: GET https://raw.githubusercontent.com/mozilla/standards-positions/gh-pages/merged-data.json "HTTP/1.1 200 OK"
[2026-05-26, 16:17:32 UTC] {pod_manager.py:477} INFO - [base] ERROR:root:1 validation error for StandardsPosition
[2026-05-26, 16:17:32 UTC] {pod_manager.py:477} INFO - [base] web_feature
[2026-05-26, 16:17:32 UTC] {pod_manager.py:477} INFO - [base]   Field required [type=missing, input_value={'position': 'positive', ...eir online experience."}, input_type=dict]
[2026-05-26, 16:17:32 UTC] {pod_manager.py:477} INFO - [base]     For further information visit https://errors.pydantic.dev/2.13/v/missing

Looks like the json has "web-feature": null field and we're expecting web_feature. Not sure if this is the right fix, but I've added an alias to map the two together as well as default null value and run it locally to unbreak the job.

@ksy36 ksy36 requested a review from a team as a code owner May 26, 2026 16:38
@ksy36 ksy36 requested a review from jgraham May 26, 2026 16:39
Copy link
Copy Markdown
Member

@jgraham jgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think this is probably a good enough fix.

@jgraham jgraham merged commit 1c40c6e into main May 27, 2026
3 checks passed
@jgraham jgraham deleted the web_feature_alias branch May 27, 2026 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants