Open
Conversation
`--all-targets` and `--all-features` are removed as well since they are unnecessary
We need to run `cargo clean` before `cargo test`. Otherwise, if there is an audio_mixer crate built before, we will end up having a "multiple matching crates for `audio_mixer`" error.
- Instead of using Makefile, using command line to run `cargo build` directly to generate the static FFI library that will be linked to audio_mixer.c - Fix the build error on Linux and Windows
- Rename mixer-core to core - Rename mixer-capi to capi
The original run_sanitizers.sh is moved to the `core` folder. By doing so, we don't need to specify the `package` run in `cargo test` by `-p`, and the paths to manifests `Cargo.toml` and `Cargo_ori.toml` is updated as well. The run_sanitizers.sh in the top folder now is just a proxy to call `run_sanitizers.sh` in core folder.
Reuse pre-built FFI library is the easiest way to avoid linking error for undefined asan/tsan/... symbols.
Open
padenot
approved these changes
May 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To use this crate in cubeb on Windows as well, we need to create some C APIs.