Conversation
annasob
reviewed
May 1, 2026
| #[test] | ||
| fn test_build_url_with_date() { | ||
| let options = WorldCupQueryParams { | ||
| date: Some("2026-06-15".to_string()), |
There was a problem hiding this comment.
non blocking but lets update these dates to use something like Duration::from_secs
annasob
reviewed
May 1, 2026
| /// Fetch World Cup data | ||
| WorldCup { | ||
| /// OHTTP relay URL | ||
| #[arg(long, default_value = "https://ohttp-merino.mozilla.fastly-edge.com")] |
There was a problem hiding this comment.
Nan said no need for OHTTP since no search data is being passed.
annasob
requested changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
[ci full]to the PR title.