Skip to content

Bug 2027114 - Produce expected data format in nimbus-cli list command#7341

Merged
freshstrangemusic merged 1 commit intomainfrom
freshstrangemusic/push-mqxvzvxzzosq
Apr 29, 2026
Merged

Bug 2027114 - Produce expected data format in nimbus-cli list command#7341
freshstrangemusic merged 1 commit intomainfrom
freshstrangemusic/push-mqxvzvxzzosq

Conversation

@freshstrangemusic
Copy link
Copy Markdown
Member

The nimbus-cli list command expects the data from the RS server to be the raw JSON payload from the HTTP request, i.e., it should have a data field with the actual record contents. Until we have time to go through the entire SDK and CLI and update the parsing (see-also bug 2002310), we just wrap the returned response in an object with a data member.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

@freshstrangemusic freshstrangemusic force-pushed the freshstrangemusic/push-mqxvzvxzzosq branch from 4bb2895 to d0a3b09 Compare April 28, 2026 14:19
@freshstrangemusic freshstrangemusic force-pushed the freshstrangemusic/push-ptnswsymmrnq branch from c177c81 to c333089 Compare April 28, 2026 14:19
Base automatically changed from freshstrangemusic/push-ptnswsymmrnq to main April 29, 2026 15:44
The nimbus-cli list command expects the data from the RS server to be
the raw JSON payload from the HTTP request, i.e., it should have a
`data` field with the actual record contents. Until we have time to go
through the entire SDK and CLI and update the parsing (see-also bug
2002310), we just wrap the returned response in an object with a data
member.
@freshstrangemusic freshstrangemusic force-pushed the freshstrangemusic/push-mqxvzvxzzosq branch from d0a3b09 to 7113432 Compare April 29, 2026 22:13
@freshstrangemusic freshstrangemusic added this pull request to the merge queue Apr 29, 2026
Merged via the queue into main with commit 8e94df1 Apr 29, 2026
14 checks passed
@freshstrangemusic freshstrangemusic deleted the freshstrangemusic/push-mqxvzvxzzosq branch April 29, 2026 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants