Skip to content

Conversation

@eviljeff
Copy link
Member

@eviljeff eviljeff commented Dec 17, 2025

Fixes: mozilla/addons#15654

Description

Exposes the versions that were restored as part of an appeal on a disable or reject action.

Context

Testing

  • define your cinder api key/secret and turn on the cinder/dsa related waffle switches
  • reject a version of an add-on via reviewer tools (makes it easier if you're one the authors)
  • in fakemail find the rejection email and go to the appeal link, and submit the appeal
  • in reviewer tools accept that appeal by un-rejecting the version
  • in reviewer tools un-reject the version
  • in reviewer tools accept that appeal by approving the version you unrejected
  • in fakemail see the email now mentions the version that was rejected, and is now re-enabled

repeat for a force disable

  • accepting the appeal is a force enable

Checklist

  • Add #ISSUENUM at the top of your PR to an existing open issue in the mozilla/addons repository.
  • Successfully verified the change locally.
  • The change is covered by automated tests, or otherwise indicated why doing so is unnecessary/impossible.
  • Add before and after screenshots (Only for changes that impact the UI).
  • Add or update relevant docs reflecting the changes made.

@eviljeff eviljeff force-pushed the 15654-update-appeal-email-template branch from a8fc47d to 47bfc1a Compare December 17, 2025 12:15
@eviljeff eviljeff marked this pull request as ready for review December 17, 2025 12:17
@eviljeff eviljeff force-pushed the 15654-update-appeal-email-template branch from 47bfc1a to da5d542 Compare December 17, 2025 12:29
@eviljeff eviljeff requested a review from willdurand December 17, 2025 13:02
@eviljeff eviljeff requested a review from diox January 5, 2026 12:46
@diox
Copy link
Member

diox commented Jan 7, 2026

in reviewer tools accept that appeal by un-rejecting the version

Won't work through unreject (or unreject multiple versions for unlisted), that action isn't set up to resolve jobs (or notify anyone)

Copy link
Member

@diox diox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works (for the reject case, need to remember to approve after unrejecting, since that's what actually resolves the appeal)

@eviljeff
Copy link
Member Author

eviljeff commented Jan 7, 2026

Works (for the reject case, need to remember to approve after unrejecting, since that's what actually resolves the appeal)

thanks. Are the testing steps correct now?

@diox
Copy link
Member

diox commented Jan 7, 2026

Yes, that's what I did to test it.

@eviljeff eviljeff merged commit 519a99e into mozilla:master Jan 7, 2026
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task]: DSA developer appeal grant email should contain text indicating that the versions may still be taken down later following another review

2 participants