chore: dead template surface — instantiate what we ship, drop what nothing uses - #61
Merged
Conversation
…vention — pqxx iteration yields row_ref
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reviews flagged template API that nothing instantiates ("a silently broken signature passes CI"). Principle applied: documented fork-facing API gets an instantiating test; undocumented-and-superseded gets deleted — every deletion grep-proven across src/tests/docs/scripts/frontend.
Deleted:
KafkaConsumer::commit()(duplicated the commitSync path), the 2-argproduceoverload,Auth::has_any_role/require_any_role/current_user_is_admin(undocumented, zero callers,require_adminroutes throughrequire_permission).Instantiated/covered:
CrudBaseowned-triple — newtest_crud_owned.cppdrives all three templates through the #42 Database seam with a fictional owned repo (the compile-guarantee the review asked for;--ownedscaffold output confirmed to exercise them too).Database::execute_transaction/IsolationLevel/execute_write_idempotent— three real integration tests (SHOW transaction_isolationper level, multi-statement rollback, idempotent replay converging) plus fork-API documentation in CONVENTIONS §3. Messaging pre-init guard smokes,Jobs::default_max_retries,Migrations::get()guard.Rewritten:
Validation::uuidnow delegates toApi::detail::is_uuid_segment— the second, regex-based UUID implementation is gone; semantics and the error contract verified against the existing tests, signature untouched (add-orgs.sh scaffold stays compatible).Gates green (test-buckets 49 unit / 35 integration with the new files, selftest 19/19).