fix(utils): saturate quantize output to avoid sign-flip wraparound - #50
Open
dlyongemallo wants to merge 1 commit into
Open
fix(utils): saturate quantize output to avoid sign-flip wraparound#50dlyongemallo wants to merge 1 commit into
dlyongemallo wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a signed wraparound bug in utils.quantize that caused full-scale positive samples (e.g., +1.0) to overflow the representable signed integer range and decode with a sign flip (impacting QSM/MQSM), by saturating/clipping instead of wrapping.
Changes:
- Add saturation (via clipping) to
quantizeto keep outputs within the signed integer range for the givenqubit_depth. - Add input validation for
qubit_depth(must be an integer ≥ 1; accepts NumPy integer scalars but rejects bools). - Add focused unit tests covering in-range behavior, positive/negative saturation, and
qubit_depthvalidation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
quantumaudio/utils/convert.py |
Clamp quantization outputs to the representable signed range and validate qubit_depth to prevent overflow-induced sign flips. |
tests/test_convert.py |
New unit tests validating saturation behavior and qubit_depth type/range handling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #49.