fix(schemes): honour execute_function in MSQPAM.decode - #48
Open
dlyongemallo wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes MSQPAM.decode so it uses the caller-provided execute_function instead of always calling utils.execute, aligning behavior with the method signature and documentation.
Changes:
- Replace the hardcoded
utils.execute(...)call withexecute_function(...)insideMSQPAM.decode.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dlyongemallo
force-pushed
the
fix_msqpam_ignores_execute_function
branch
from
April 26, 2026 19:26
47a3ea9 to
92cf05a
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSQPAM.decodecalledutils.executeinstead of theexecute_functionsupplied by the caller, which was silently ignored.