feat: add Japanese and Chinese translations for notro-docs#171
Open
mosugi wants to merge 11 commits into
Open
Conversation
- Remove 8 fixture test articles (01-callout through 08-misc) - Add 16 Japanese (ja/) translation files for all docs sections - Add 16 Chinese Simplified (zh-cn/) translation files for all docs sections - All 32 new articles pushed to Notion docs data source with Public=true Covers: getting-started, guides, reference, and deployment sections.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
…des → Reference → Deployment) https://claude.ai/code/session_01AGGjEvy5H6Si7C4E5PYqWT
…efix Add Lang select property to blog content schema and update buildSlugMap() to prepend the lang code for non-English articles, maintaining existing URL structure (/blog/ja/hello-notro/, /blog/zh-cn/hello-notro/). https://claude.ai/code/session_01AGGjEvy5H6Si7C4E5PYqWT
- Footer.astro: language switcher (English | 日本語 | 中文) that detects current lang from URL pathname and links to same article in other langs; non-article pages (index, pagination, tag) fall back to /blog/ - blog.test.ts: add makeEntry lang support and two new buildSlugMap tests for lang prefix behavior (non-en prepends lang/, null treated as en)
Show the switcher only when on an article page (isArticle=true). On blog listing, pagination, tag, and home pages the current lang cannot be determined and all links would point to /blog/, making the switcher appear broken.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Covers: getting-started, guides, reference, and deployment sections.