Fix Windows Unicode API usage and ntstatus header conflicts#2
Merged
Conversation
Agent-Logs-Url: https://github.com/mostwise/RedSun/sessions/436ebc85-bc23-48b0-aad3-05862fc22ac3 Co-authored-by: mostwise <100317628+mostwise@users.noreply.github.com>
Agent-Logs-Url: https://github.com/mostwise/RedSun/sessions/436ebc85-bc23-48b0-aad3-05862fc22ac3 Co-authored-by: mostwise <100317628+mostwise@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
mostwise
April 30, 2026 16:10
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows build was failing with widespread
ntstatus.hmacro redefinitions andC2664errors from passingwchar_tstrings to ANSI WinAPI functions. These changes align header ordering and API variants to remove the conflicts and mismatched types.WIN32_NO_STATUSbeforeWindows.hand includentstatus.hafter to avoid duplicate macro definitions.*Acalls to*Wvariants and align related structures to matchwchar_tliterals.Example: