Skip to content

https-dns-proxy: correct duplicate nft rules and error tracking #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
egc112 wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −8
Draft

https-dns-proxy: correct duplicate nft rules and error tracking #8

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a04eb6
Refactor https-dns-proxy init script for nftables
egc112 Apr 30, 2026
c16da3a
Merge pull request #1 from egc112/egc112-patch-1
egc112 Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions files/etc/init.d/https-dns-proxy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,13 +145,11 @@ notrack_nft() {
return
fi
new_content="$(cat <<-EOF
table inet https_dns_proxy_notrack {
chain raw_output {
type filter hook output priority raw; policy accept;
meta l4proto { tcp, udp } th dport { ${port_set} } ip daddr 127.0.0.0/8 notrack
meta l4proto { tcp, udp } th sport { ${port_set} } ip saddr 127.0.0.0/8 notrack
}
}
add table inet https_dns_proxy_notrack
flush table inet https_dns_proxy_notrack
add chain inet https_dns_proxy_notrack raw_output { type filter hook output priority raw; policy accept; }
add rule inet https_dns_proxy_notrack raw_output meta l4proto { tcp, udp } th dport { ${port_set} } ip daddr 127.0.0.0/8 notrack
add rule inet https_dns_proxy_notrack raw_output meta l4proto { tcp, udp } th sport { ${port_set} } ip saddr 127.0.0.0/8 notrack
EOF
)"
existing_content="$(cat "$NOTRACK_NFT_FILE" 2>/dev/null)"
Expand Down Expand Up @@ -425,7 +423,7 @@ stop_service() {
uci_commit 'dhcp'
dnsmasq_restart || _error=1
fi
notrack_nft remove
notrack_nft remove || _error=1
# shellcheck disable=SC2015
[ -z "$_error" ] && output_okn || output_failn
}
Expand Down
Loading