Skip to content

Fix NoneType crash when PartnerManager returns null response #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ckm007 merged 1 commit into from
Jun 30, 2026
Merged

Fix NoneType crash when PartnerManager returns null response #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion certmanager/checkupdate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,7 @@ def upload_certificate_to_partnermanager(token, cert_data, partner_id, base_url,
print(f" [{partner_id}] Upload to PartnerManager failed (HTTP {response.status_code}): {error_text}")
return None

signed_certificate = response_json.get("response", {}).get("signedCertificateData")
signed_certificate = (response_json.get("response") or {}).get("signedCertificateData")
if not isinstance(signed_certificate, str) or not signed_certificate.strip():
print(f" [{partner_id}] Upload to PartnerManager succeeded but signedCertificateData is missing.")
return None
Expand Down
Loading