[MOSIP-37808] Updated DB attributes of MOSIP .#135
Merged
Conversation
Signed-off-by: Abhi <abhishek.shankarcs@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughConsolidates per-database Helm templates into parameterized ChangesHelm template consolidation and parameterized database initialization
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@helm/postgres-init/templates/env-configmap.yaml`:
- Around line 30-31: The template currently omits ENV_VERSION_FLAG when its
value is false because it uses a truthy check; change the conditional to check
for presence/definedness instead of truthiness so false is rendered (e.g.,
replace the truthy guard with a nil-check such as testing eq
$dbVal.ENV_VERSION_FLAG nil or using not eq nil) and keep the existing rendering
line ENV_VERSION_FLAG: {{ $dbVal.ENV_VERSION_FLAG | quote }} so the key is
emitted when explicitly set to false but still omitted when truly undefined.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 0174c85e-44f3-4da0-8183-82d61efbce6a
📒 Files selected for processing (48)
deploy/postgres-init-values.yamlhelm/postgres-init/templates/audit-env-configmap.yamlhelm/postgres-init/templates/audit-job.yamlhelm/postgres-init/templates/credential-env-configmap.yamlhelm/postgres-init/templates/credential-job.yamlhelm/postgres-init/templates/digitalcard-env-configmap.yamlhelm/postgres-init/templates/digitalcard-job.yamlhelm/postgres-init/templates/env-configmap.yamlhelm/postgres-init/templates/esignet-env-configmap.yamlhelm/postgres-init/templates/esignet-job.yamlhelm/postgres-init/templates/hotlist-env-configmap.yamlhelm/postgres-init/templates/hotlist-job.yamlhelm/postgres-init/templates/ida-env-configmap.yamlhelm/postgres-init/templates/ida-job.yamlhelm/postgres-init/templates/idmap-env-configmap.yamlhelm/postgres-init/templates/idmap-job.yamlhelm/postgres-init/templates/idrepo-env-configmap.yamlhelm/postgres-init/templates/idrepo-job.yamlhelm/postgres-init/templates/inji-certify-env-configmap.yamlhelm/postgres-init/templates/inji-certify-job.yamlhelm/postgres-init/templates/inji-mimoto-env-configmap.yamlhelm/postgres-init/templates/inji-mimoto-job.yamlhelm/postgres-init/templates/inji-verify-env-configmap.yamlhelm/postgres-init/templates/inji-verify-job.yamlhelm/postgres-init/templates/job.yamlhelm/postgres-init/templates/kernel-env-configmap.yamlhelm/postgres-init/templates/kernel-job.yamlhelm/postgres-init/templates/keymgr-env-configmap.yamlhelm/postgres-init/templates/keymgr-job.yamlhelm/postgres-init/templates/master-env-configmap.yamlhelm/postgres-init/templates/master-job.yamlhelm/postgres-init/templates/mockidentitysystem-env-configmap.yamlhelm/postgres-init/templates/mockidentitysystem-job.yamlhelm/postgres-init/templates/otp-env-configmap.yamlhelm/postgres-init/templates/otp-job.yamlhelm/postgres-init/templates/pms-env-configmap.yamlhelm/postgres-init/templates/pms-job.yamlhelm/postgres-init/templates/prereg-env-configmap.yamlhelm/postgres-init/templates/prereg-job.yamlhelm/postgres-init/templates/regprc-env-configmap.yamlhelm/postgres-init/templates/regprc-job.yamlhelm/postgres-init/templates/resident-env-configmap.yamlhelm/postgres-init/templates/resident-job.yamlhelm/postgres-init/templates/toolkit-env-configmap.yamlhelm/postgres-init/templates/toolkit-job.yamlhelm/postgres-init/values.yamlpostgres-init/Dockerfilepostgres-init/postgres-init.sh
💤 Files with no reviewable changes (42)
- helm/postgres-init/templates/prereg-env-configmap.yaml
- helm/postgres-init/templates/digitalcard-env-configmap.yaml
- helm/postgres-init/templates/inji-mimoto-env-configmap.yaml
- helm/postgres-init/templates/hotlist-env-configmap.yaml
- helm/postgres-init/templates/resident-env-configmap.yaml
- helm/postgres-init/templates/idrepo-job.yaml
- helm/postgres-init/templates/inji-certify-job.yaml
- helm/postgres-init/templates/idmap-env-configmap.yaml
- helm/postgres-init/templates/kernel-env-configmap.yaml
- helm/postgres-init/templates/hotlist-job.yaml
- helm/postgres-init/templates/esignet-job.yaml
- helm/postgres-init/templates/mockidentitysystem-env-configmap.yaml
- helm/postgres-init/templates/audit-env-configmap.yaml
- helm/postgres-init/templates/idmap-job.yaml
- helm/postgres-init/templates/keymgr-env-configmap.yaml
- helm/postgres-init/templates/prereg-job.yaml
- helm/postgres-init/templates/keymgr-job.yaml
- helm/postgres-init/templates/pms-job.yaml
- helm/postgres-init/templates/master-job.yaml
- helm/postgres-init/templates/toolkit-env-configmap.yaml
- helm/postgres-init/templates/toolkit-job.yaml
- helm/postgres-init/templates/inji-mimoto-job.yaml
- helm/postgres-init/templates/inji-verify-env-configmap.yaml
- helm/postgres-init/templates/resident-job.yaml
- helm/postgres-init/templates/regprc-job.yaml
- helm/postgres-init/templates/ida-job.yaml
- helm/postgres-init/templates/idrepo-env-configmap.yaml
- helm/postgres-init/templates/master-env-configmap.yaml
- helm/postgres-init/templates/regprc-env-configmap.yaml
- helm/postgres-init/templates/inji-verify-job.yaml
- helm/postgres-init/templates/credential-env-configmap.yaml
- helm/postgres-init/templates/mockidentitysystem-job.yaml
- helm/postgres-init/templates/esignet-env-configmap.yaml
- helm/postgres-init/templates/otp-env-configmap.yaml
- helm/postgres-init/templates/digitalcard-job.yaml
- helm/postgres-init/templates/ida-env-configmap.yaml
- helm/postgres-init/templates/otp-job.yaml
- helm/postgres-init/templates/pms-env-configmap.yaml
- helm/postgres-init/templates/audit-job.yaml
- helm/postgres-init/templates/inji-certify-env-configmap.yaml
- helm/postgres-init/templates/credential-job.yaml
- helm/postgres-init/templates/kernel-job.yaml
ckm007
reviewed
May 19, 2026
ckm007
left a comment
ckm007
left a comment
Member
There was a problem hiding this comment.
Add comments in values of helm and install.
Signed-off-by: Abhi <abhishek.shankarcs@gmail.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@helm/postgres-init/values.yaml`:
- Around line 35-37: The commented scaffold lines for readOnlyRootFilesystem,
runAsNonRoot, runAsUser and for requests are currently top-level; move them so
they are indented under their parent mapping keys (securityContext for
readOnlyRootFilesystem/runAsNonRoot/runAsUser and resources for requests) so
that if uncommented they become nested entries rather than new top-level
keys—adjust indentation to match the surrounding YAML block style for the
securityContext and resources entries (preserve the existing comment markers).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: fb6df35c-b82d-4e46-be29-99777d8caab7
📒 Files selected for processing (2)
deploy/postgres-init-values.yamlhelm/postgres-init/values.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
- deploy/postgres-init-values.yaml
Signed-off-by: Abhi <abhishek.shankarcs@gmail.com>
Signed-off-by: Abhi <abhishek.shankarcs@gmail.com>
ckm007
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Improvements