Skip to content

[MOSIP-44060, MOSIP-44106, DSD-9381, DSD-9092] Port release-1.3.x imp…#207

Merged
ckm007 merged 1 commit into
mosip:developfrom
ckm007:port/release-1.3.x-to-develop
Jun 4, 2026
Merged

[MOSIP-44060, MOSIP-44106, DSD-9381, DSD-9092] Port release-1.3.x imp…#207
ckm007 merged 1 commit into
mosip:developfrom
ckm007:port/release-1.3.x-to-develop

Conversation

@ckm007

@ckm007 ckm007 commented Jun 4, 2026

Copy link
Copy Markdown
Member

…rovements to develop

  • Enhanced deploy/install.sh with pre-installation domain validation loop, PostgreSQL image settings, mosip helm repo for istio-addons, and expanded install flags for readability; keycloak image kept as mosipqa/mosip-artemis-keycloak:develop
  • Add deploy/istio-addons-values.yaml replacing local chart/istio-addons
  • Remove deploy/chart/istio-addons/ (local chart replaced by mosip/istio-addons helm repo chart)
  • Update README.md: fix badge workflow name (push-trigger.yml), restructure with Documentation and Contribution & Community sections

Summary by CodeRabbit

  • Documentation

    • Updated README with new community and contribution sections
  • Chores

    • Reorganized Istio add-ons chart configuration and templates
    • Enhanced installation script with pre-install validation to verify host configuration before deployment
    • Added new configuration values file for Istio add-ons setup

…rovements to develop

- Enhanced deploy/install.sh with pre-installation domain validation loop,
  PostgreSQL image settings, mosip helm repo for istio-addons, and expanded
  install flags for readability; keycloak image kept as mosipqa/mosip-artemis-keycloak:develop
- Add deploy/istio-addons-values.yaml replacing local chart/istio-addons
- Remove deploy/chart/istio-addons/ (local chart replaced by mosip/istio-addons helm repo chart)
- Update README.md: fix badge workflow name (push-trigger.yml), restructure
  with Documentation and Contribution & Community sections

Signed-off-by: ckm007 <chandrakeshavmishra@gmail.com>
@coderabbitai

coderabbitai Bot commented Jun 4, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

Walkthrough

This PR migrates Istio addons deployment from a local Helm chart to a remote repository-based chart. The local chart files are removed, configuration is externalized to a values file, and the install script is refactored to support chart versioning and pre-deployment validation.

Changes

Istio Addons Chart Migration

Layer / File(s) Summary
Chart externalization and values migration
deploy/chart/istio-addons/values.yaml, deploy/istio-addons-values.yaml
Local chart files (Chart.yaml, gateway.yaml, virtualservice.yaml, values.yaml) are removed, and configuration is externalized into a new istio-addons-values.yaml file for the remote mosip/istio-addons chart deployment.
Install script migration to remote chart with validation
deploy/install.sh
Introduces ISTIO_ADDONS_CHART_VERSION variable, adds pre-installation validation that checks and optionally updates the Keycloak host in the values file, updates Keycloak installation with explicit PostgreSQL image settings, and migrates Istio addons installation to use the remote chart with the externalized values file instead of inline --set flags.
Documentation updates
README.md
Updates the build badge URL and adds new "Documentation" and "Contribution & Community" sections with relevant links.

Sequence Diagram

sequenceDiagram
    participant User
    participant InstallScript as install.sh
    participant YAMLConfig as istio-addons-values.yaml
    participant HelmRepo as mosip Helm Repo
    participant Keycloak
    participant IstioAddons

    User->>InstallScript: Run install
    InstallScript->>InstallScript: Load ISTIO_ADDONS_CHART_VERSION
    InstallScript->>YAMLConfig: Read host value
    YAMLConfig-->>InstallScript: Return configured host
    alt Host is default placeholder
        InstallScript->>User: Prompt to update host
        User->>YAMLConfig: Update via sed
        YAMLConfig-->>InstallScript: Confirm updated
    end
    InstallScript->>HelmRepo: Add mosip repo
    InstallScript->>Keycloak: helm install with PostgreSQL settings
    Keycloak-->>InstallScript: Installation complete
    InstallScript->>HelmRepo: Install mosip/istio-addons
    HelmRepo->>IstioAddons: Deploy using istio-addons-values.yaml
    IstioAddons-->>InstallScript: Deployment complete
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

🐰 A local chart takes flight,
Spreading wings to remote height,
Values dance in their own file,
Install scripts validate with style,
Mosip addons bloom so bright! 🚀

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title references JIRA issue identifiers but is truncated, cutting off the main change description mid-sentence ('Port release-1.3.x imp…'), making the primary objective unclear. Complete the title with the full change description, e.g., 'Port release-1.3.x improvements to develop' or summarize the main change concisely without truncation.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ckm007 ckm007 merged commit 3dd5a2d into mosip:develop Jun 4, 2026
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant