[MOSIP-44060, MOSIP-44106, DSD-9381, DSD-9092] Port release-1.3.x imp…#207
Conversation
…rovements to develop - Enhanced deploy/install.sh with pre-installation domain validation loop, PostgreSQL image settings, mosip helm repo for istio-addons, and expanded install flags for readability; keycloak image kept as mosipqa/mosip-artemis-keycloak:develop - Add deploy/istio-addons-values.yaml replacing local chart/istio-addons - Remove deploy/chart/istio-addons/ (local chart replaced by mosip/istio-addons helm repo chart) - Update README.md: fix badge workflow name (push-trigger.yml), restructure with Documentation and Contribution & Community sections Signed-off-by: ckm007 <chandrakeshavmishra@gmail.com>
|
Caution Review failedPull request was closed or merged during review WalkthroughThis PR migrates Istio addons deployment from a local Helm chart to a remote repository-based chart. The local chart files are removed, configuration is externalized to a values file, and the install script is refactored to support chart versioning and pre-deployment validation. ChangesIstio Addons Chart Migration
Sequence DiagramsequenceDiagram
participant User
participant InstallScript as install.sh
participant YAMLConfig as istio-addons-values.yaml
participant HelmRepo as mosip Helm Repo
participant Keycloak
participant IstioAddons
User->>InstallScript: Run install
InstallScript->>InstallScript: Load ISTIO_ADDONS_CHART_VERSION
InstallScript->>YAMLConfig: Read host value
YAMLConfig-->>InstallScript: Return configured host
alt Host is default placeholder
InstallScript->>User: Prompt to update host
User->>YAMLConfig: Update via sed
YAMLConfig-->>InstallScript: Confirm updated
end
InstallScript->>HelmRepo: Add mosip repo
InstallScript->>Keycloak: helm install with PostgreSQL settings
Keycloak-->>InstallScript: Installation complete
InstallScript->>HelmRepo: Install mosip/istio-addons
HelmRepo->>IstioAddons: Deploy using istio-addons-values.yaml
IstioAddons-->>InstallScript: Deployment complete
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…rovements to develop
Summary by CodeRabbit
Documentation
Chores