Skip to content

MOSIP-38979 - Updated the code for taking dynamic request body for updating identity#1760

Open
mohanachandran-s wants to merge 3 commits into
mosip:developfrom
mohanachandran-s:develop
Open

MOSIP-38979 - Updated the code for taking dynamic request body for updating identity#1760
mohanachandran-s wants to merge 3 commits into
mosip:developfrom
mohanachandran-s:develop

Conversation

@mohanachandran-s

@mohanachandran-s mohanachandran-s commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

MOSIP-38979 - Updated the code for taking dynamic request body for updating identity

Summary by CodeRabbit

  • Bug Fixes
    • Improved the identity update test flow by automatically selecting the appropriate request template during execution.
    • This helps keep generated test requests aligned with the latest identity update format.

…ma driven request body

Signed-off-by: Mohanachandran S <mohanachandran.s@technoforte.co.in>
Signed-off-by: Mohanachandran S <mohanachandran.s@technoforte.co.in>

# Conflicts:
#	api-test/agents.md
…dating identity

Signed-off-by: Mohanachandran S <mohanachandran.s@technoforte.co.in>
@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 34ac4262-b3de-4ae1-af28-e5da57cb668e

📥 Commits

Reviewing files that changed from the base of the PR and between c675c78 and 77f761a.

📒 Files selected for processing (1)
  • api-test/src/main/java/io/mosip/testrig/apirig/auth/testscripts/UpdateIdentity.java

Walkthrough

UpdateIdentity now imports AdminTestUtil and uses it to set testCaseDTO.inputTemplate during updateIdentity(...) based on the regenerate-HBS flag.

Changes

Identity template update

Layer / File(s) Summary
Template selection
api-test/src/main/java/io/mosip/testrig/apirig/auth/testscripts/UpdateIdentity.java
UpdateIdentity adds an AdminTestUtil import and sets testCaseDTO.inputTemplate from AdminTestUtil.updateIdentityHbs(testCaseDTO.isRegenerateHbs()) inside updateIdentity(...).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • lsivanand
  • mahammedtaheer

Poem

A bunny hopped in the test rig light,
Switched templates left and right. 🐇
One little HBS hop,
Then the payload did not stop,
And the identity run felt just right.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: updating identity handling to use a dynamic request body.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants