MOSIP-45235- Automte demoauth test cases

[jayesh12234]

Summary by CodeRabbit

• New Features

  • Expanded demo authentication test coverage for multiple authToken modes (policy, partner/policy-based, and random), including repeat-call and cross-partner token behavior.
  • Added new auth-policy configurations for policy-token and random-token allowed auth types and KYC attribute/language constraints.

• Bug Fixes

  • Improved demo auth handling for invalid thumbprint cases and ensured token-related placeholder substitutions and dynamic output expectations resolve correctly.

• Tests

  • Added Handlebars templates and extended YAML scenarios, including a new negative KYC-exchange case for missing/invalid kycAuth.

[coderabbitai]

Warning

Review limit reached

@jayesh12234, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 41 minutes and 49 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 19a3b48d-db1a-450c-a566-59620d5796af

📥 Commits

Reviewing files that changed from the base of the PR and between d77d124 and 3df4be8.

📒 Files selected for processing (3)

• api-test/src/main/java/io/mosip/testrig/apirig/auth/testrunner/MosipTestRunner.java
• api-test/src/main/java/io/mosip/testrig/apirig/auth/utils/IdAuthenticationUtil.java
• api-test/src/main/resources/ida/DemoAuth/DemoAuth2.yml

Walkthrough

Adds auth-policy setup, extends DemoAuth placeholder and output handling, and introduces new authToken and kyc-exchange test cases with matching response templates.

Changes

Auth token demo coverage

Layer / File(s)	Summary
Policy setup api-test/src/main/resources/config/AuthPolicyForPolicyTokenAllowedAuthTypes.json, api-test/src/main/resources/config/AuthPolicyForRandomTokenAllowedAuthTypes.json, api-test/src/main/java/io/mosip/testrig/apirig/auth/utils/IdAuthenticationUtil.java	Adds auth-policy resources for policy and random token types, plus helper methods to create, publish, and map those policies.
Runner wiring api-test/src/main/java/io/mosip/testrig/apirig/auth/testrunner/MosipTestRunner.java	Declares new partner key URL variables and populates them through the new policy-token and random-token setup calls.
DemoAuth flow api-test/src/main/java/io/mosip/testrig/apirig/auth/testscripts/DemoAuth.java	Adds new endpoint placeholders, copies the encrypted-session map for invalid thumbprints, and validates keyword-expanded expected output.
AuthToken cases api-test/src/main/resources/ida/DemoAuth/DemoAuth2.yml, api-test/src/main/resources/ida/DemoAuth/DemoAuthResultWithAuthToken.hbs	Adds authToken assertions for policy, partner, and random token cases, with a response template for authStatus and authToken.
Kyc exchange negative case api-test/src/main/resources/ida/DemoAuthKycExchange/DemoAuthKycExchange.yml, api-test/src/main/resources/ida/DemoAuthKycExchange/DemoAuthKycExchangeError.hbs	Adds a delegated kyc-exchange negative scenario that expects IDA-KYE-001, with an error-response template.

Sequence Diagram(s)

sequenceDiagram
  participant MosipTestRunner
  participant IdAuthenticationUtil
  participant PartnerRegistration
  participant RestClient

  MosipTestRunner->>IdAuthenticationUtil: createAndPublishPolicyWithPolicyTokenType()
  IdAuthenticationUtil->>PartnerRegistration: registerSecondPolicyTokenPartner()
  IdAuthenticationUtil->>RestClient: PATCH API key
  IdAuthenticationUtil-->>MosipTestRunner: policyTokenPartnerKeyUrl

  MosipTestRunner->>IdAuthenticationUtil: createAndPublishPolicyWithRandomTokenType()
  IdAuthenticationUtil->>PartnerRegistration: registerThirdPolicyTokenPartner()
  IdAuthenticationUtil->>RestClient: PATCH API key
  IdAuthenticationUtil-->>MosipTestRunner: randomTokenPartnerKeyUrl

Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes

Poem

🐰 Hop, hop, new tokens shine so bright,
Policy carrots sprout just right.
DemoAuth nibbles authToken treats,
Kyc-exchange drums a tiny beat.
I twitch my nose—test bunnies delight!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 65.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title matches the main change: automating DemoAuth test cases.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 4

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@api-test/src/main/java/io/mosip/testrig/apirig/auth/testrunner/MosipTestRunner.java`:
- Around line 130-151: The MosipTestRunner initialization flow is logging
generated partner key URLs that contain sensitive auth material. Remove the
LOGGER.info calls for policyToken2PartnerKeyURL, partnerToken2KeyURL,
policyToken3PartnerKeyURL, randomTokenPartnerKeyURL, randomToken2PartnerKeyURL,
and randomToken3PartnerKeyURL, while keeping the underlying IdAuthenticationUtil
calls intact so the values are still generated and assigned for test use.

In
`@api-test/src/main/java/io/mosip/testrig/apirig/auth/utils/IdAuthenticationUtil.java`:
- Around line 425-443: The cross-policy partner setup in IdAuthenticationUtil
uses deterministic partner IDs that can collide across repeated or parallel
runs. Update registerSecondPolicyTokenPartner and the policyToken2PartnerId /
policyToken3PartnerId initialization to generate run-unique IDs (for example by
incorporating a timestamp or random suffix) while keeping the organization/email
pairing consistent, and ensure generateAndGetSecondPolicyTokenPartnerKeyUrl and
the policyToken3 path use the new dynamic IDs.
- Around line 223-237: The setup flow in IdAuthenticationUtil is parsing and
continuing without checking REST call results, so add explicit status-code
validation around the create-policy, publish-policy, and related setup requests
before reading the body or proceeding. Use the Response returned by
RestClient.postRequestWithCookie/patchRequestWithCookie in the affected methods,
verify success immediately, and throw a clear SkipException with context on any
non-2xx response. Apply the same fail-fast pattern to the admin token fetch, API
key update, and partner key registration paths so the setup stops cleanly
instead of surfacing JSONException or using invalid tokens.

In `@api-test/src/main/resources/ida/DemoAuth/DemoAuth2.yml`:
- Line 238: The authToken regex validations rely on a negative lookahead without
a leading start anchor, so they may not enforce full-string matching
consistently. Update the affected authToken checks in DemoAuth2.yml at the
patterns used by the validation entries referenced by the auth token assertions
to add explicit anchors such as ^ and $, so the entire token is matched rather
than a substring. If OutputValidationUtil already guarantees full-match behavior
via String.matches(), add a brief documentation comment near the relevant
validation usage to make that assumption explicit and prevent future confusion.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 45d9a18e-3953-486e-a965-b36920dd51d1

📥 Commits

Reviewing files that changed from the base of the PR and between c675c78 and 15edf85.

📒 Files selected for processing (9)

• api-test/src/main/java/io/mosip/testrig/apirig/auth/testrunner/MosipTestRunner.java
• api-test/src/main/java/io/mosip/testrig/apirig/auth/testscripts/DemoAuth.java
• api-test/src/main/java/io/mosip/testrig/apirig/auth/utils/IdAuthenticationUtil.java
• api-test/src/main/resources/config/AuthPolicyForPolicyTokenAllowedAuthTypes.json
• api-test/src/main/resources/config/AuthPolicyForRandomTokenAllowedAuthTypes.json
• api-test/src/main/resources/ida/DemoAuth/DemoAuth2.yml
• api-test/src/main/resources/ida/DemoAuth/DemoAuthResultWithAuthToken.hbs
• api-test/src/main/resources/ida/DemoAuthKycExchange/DemoAuthKycExchange.yml
• api-test/src/main/resources/ida/DemoAuthKycExchange/DemoAuthKycExchangeError.hbs