Improve usability with configurable fonts, symbol search, and bug fixes - #469
Open
AbhiAgnal wants to merge 7 commits into
Open
Improve usability with configurable fonts, symbol search, and bug fixes#469AbhiAgnal wants to merge 7 commits into
AbhiAgnal wants to merge 7 commits into
Conversation
mortbopet
reviewed
Aug 17, 2026
mortbopet
left a comment
mortbopet
left a comment
Owner
There was a problem hiding this comment.
Thanks for the PR - a few comments.
| StageIndex sid = {laneIt.first, stageIdx}; | ||
| auto *stagelabel = new vsrtl::Label(topLevelComponent, "-"); | ||
| stagelabel->setPointSize(14); | ||
| stagelabel->setPointSize(16); |
Owner
There was a problem hiding this comment.
from one magic constant to another. I remember back when i developed this, i had issues with font scaling across different systems... Have you checked that this new font size for stage labels is reasonable on e.g. both Windows and Linux systems?
Comment on lines
+38
to
+39
| {RIPES_SETTING_EDITORFONT, QFont(Fonts::monospace, 11)}, | ||
| {RIPES_SETTING_EXECUTABLECODEFONT, QFont(Fonts::monospace, 11)}, |
Owner
There was a problem hiding this comment.
Can you provide a compelling argument for why we need separate fonts for the editor and executable code? Allowing for changing the font is perfectly reasonable, but to avoid settings bloat, i'd wager on sharing a single font for the editor and executable code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR contains several usability improvements and bug fixes for Ripes.
Improvements
Bug fixes
Tested